* [PATCH] cfg80211: Fix grammar issue in error message
@ 2017-06-08 8:01 Martin Michlmayr
2017-06-08 8:23 ` Arend van Spriel
0 siblings, 1 reply; 6+ messages in thread
From: Martin Michlmayr @ 2017-06-08 8:01 UTC (permalink / raw)
To: Arend van Spriel, Franky Lin, Hante Meuleman
Cc: linux-wireless, brcm80211-dev-list.pdl
Fix grammar issue in error message about ISO3166.
Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index cd1d6730eab7..c1ad81f34658 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -6767,7 +6767,7 @@ static void brcmf_cfg80211_reg_notifier(struct wiphy *wiphy,
/* ignore non-ISO3166 country codes */
for (i = 0; i < sizeof(req->alpha2); i++)
if (req->alpha2[i] < 'A' || req->alpha2[i] > 'Z') {
- brcmf_err("not a ISO3166 code (0x%02x 0x%02x)\n",
+ brcmf_err("not an ISO3166 code (0x%02x 0x%02x)\n",
req->alpha2[0], req->alpha2[1]);
return;
}
--
Martin Michlmayr
http://www.cyrius.com/
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] cfg80211: Fix grammar issue in error message
2017-06-08 8:01 [PATCH] cfg80211: Fix grammar issue in error message Martin Michlmayr
@ 2017-06-08 8:23 ` Arend van Spriel
2017-06-10 9:22 ` [PATCH] brcmfmac: iso " Martin Michlmayr
0 siblings, 1 reply; 6+ messages in thread
From: Arend van Spriel @ 2017-06-08 8:23 UTC (permalink / raw)
To: Martin Michlmayr, Franky Lin, Hante Meuleman
Cc: linux-wireless, brcm80211-dev-list.pdl
Please use the driver name as prefix, ie. brcmfmac: iso cfg80211:
On 08-06-17 10:01, Martin Michlmayr wrote:
> Fix grammar issue in error message about ISO3166.
Other than that....
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] brcmfmac: iso cfg80211: Fix grammar issue in error message
2017-06-08 8:23 ` Arend van Spriel
@ 2017-06-10 9:22 ` Martin Michlmayr
2017-06-10 9:33 ` Arend van Spriel
0 siblings, 1 reply; 6+ messages in thread
From: Martin Michlmayr @ 2017-06-10 9:22 UTC (permalink / raw)
To: Arend van Spriel
Cc: Franky Lin, Hante Meuleman, linux-wireless,
brcm80211-dev-list.pdl
Fix grammar issue in error message about ISO3166.
Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index cd1d6730eab7..c1ad81f34658 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -6767,7 +6767,7 @@ static void brcmf_cfg80211_reg_notifier(struct wiphy *wiphy,
/* ignore non-ISO3166 country codes */
for (i = 0; i < sizeof(req->alpha2); i++)
if (req->alpha2[i] < 'A' || req->alpha2[i] > 'Z') {
- brcmf_err("not a ISO3166 code (0x%02x 0x%02x)\n",
+ brcmf_err("not an ISO3166 code (0x%02x 0x%02x)\n",
req->alpha2[0], req->alpha2[1]);
return;
}
--
Martin Michlmayr
http://www.cyrius.com/
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] brcmfmac: iso cfg80211: Fix grammar issue in error message
2017-06-10 9:22 ` [PATCH] brcmfmac: iso " Martin Michlmayr
@ 2017-06-10 9:33 ` Arend van Spriel
2017-06-10 9:40 ` [PATCH V3] brcmfmac: " Martin Michlmayr
0 siblings, 1 reply; 6+ messages in thread
From: Arend van Spriel @ 2017-06-10 9:33 UTC (permalink / raw)
To: Martin Michlmayr
Cc: Franky Lin, Hante Meuleman, linux-wireless,
brcm80211-dev-list.pdl
Hah. That is (unintended?) fun. I actually meant to change the subject
from "cfg80211: Fix grammar issue in error message" into "brcmfmac: Fix
grammar issue in error message". Using the abbreviation "iso" in this
context was maybe a bit misleading of me.
One more purely educational note: when sending a reworked patch it is
good practice to use "[PATCH V2]" in the subject and add a changelog
between the signature tags and the diff separated by "---" so people now
what changed, ie.:
---
changes:
V2:
- updated subject prefix.
---
Thanks,
Arend
On 10-06-17 11:22, Martin Michlmayr wrote:
> Fix grammar issue in error message about ISO3166.
>
> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index cd1d6730eab7..c1ad81f34658 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -6767,7 +6767,7 @@ static void brcmf_cfg80211_reg_notifier(struct wiphy *wiphy,
> /* ignore non-ISO3166 country codes */
> for (i = 0; i < sizeof(req->alpha2); i++)
> if (req->alpha2[i] < 'A' || req->alpha2[i] > 'Z') {
> - brcmf_err("not a ISO3166 code (0x%02x 0x%02x)\n",
> + brcmf_err("not an ISO3166 code (0x%02x 0x%02x)\n",
> req->alpha2[0], req->alpha2[1]);
> return;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH V3] brcmfmac: Fix grammar issue in error message
2017-06-10 9:33 ` Arend van Spriel
@ 2017-06-10 9:40 ` Martin Michlmayr
2017-06-13 6:59 ` [V3] " Kalle Valo
0 siblings, 1 reply; 6+ messages in thread
From: Martin Michlmayr @ 2017-06-10 9:40 UTC (permalink / raw)
To: Arend van Spriel
Cc: Franky Lin, Hante Meuleman, linux-wireless,
brcm80211-dev-list.pdl
Fix grammar issue in error message about ISO3166.
Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
changes:
V2 + V3:
- updated subject prefix.
---
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index cd1d6730eab7..c1ad81f34658 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -6767,7 +6767,7 @@ static void brcmf_cfg80211_reg_notifier(struct wiphy *wiphy,
/* ignore non-ISO3166 country codes */
for (i = 0; i < sizeof(req->alpha2); i++)
if (req->alpha2[i] < 'A' || req->alpha2[i] > 'Z') {
- brcmf_err("not a ISO3166 code (0x%02x 0x%02x)\n",
+ brcmf_err("not an ISO3166 code (0x%02x 0x%02x)\n",
req->alpha2[0], req->alpha2[1]);
return;
}
--
Martin Michlmayr
http://www.cyrius.com/
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-13 6:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-08 8:01 [PATCH] cfg80211: Fix grammar issue in error message Martin Michlmayr
2017-06-08 8:23 ` Arend van Spriel
2017-06-10 9:22 ` [PATCH] brcmfmac: iso " Martin Michlmayr
2017-06-10 9:33 ` Arend van Spriel
2017-06-10 9:40 ` [PATCH V3] brcmfmac: " Martin Michlmayr
2017-06-13 6:59 ` [V3] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).