From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Intel Linux Wireless <ilw@linux.intel.com>, <gregkh@suse.de>,
<linux-wireless@vger.kernel.org>, <vmehta@atheros.com>,
Wey-Yi Guy <wey-yi.w.guy@intel.com>,
<devel@linuxdriverproject.org>, <naveen.singh@atheros.com>,
<stable@kernel.org>
Subject: Re: [RTF] iwmc3200wifi: fix device registration ordering for cfg80211
Date: Fri, 18 Mar 2011 20:03:59 +0200 [thread overview]
Message-ID: <a86de09887dbbf9a5e6d1d1018521a5d@secure.sipsolutions.net> (raw)
In-Reply-To: <AANLkTimHyHuTnHfTddsbtiBL1CdxjJDtoJ7gnuVhxbNQ@mail.gmail.com>
On Fri, 18 Mar 2011 10:41:53 -0700, Luis R. Rodriguez wrote:
>> On Fri, Mar 18, 2011 at 6:50 AM, John W. Linville
>>> Does anyone even have this hardware?
I don't think it even exists any more.
> So similarly here we can likely hit a case where we hit the double
> wiphy_unregister() twice and I think we'd oops. My preference is to
> make wiphy_unregister() re-entrant and let us detect when the device
> already was unregistered. Johannes?
I don't like that, it encourages sloppy driver writing. Seriously,
why is it so hard to properly write the code?
You can fail during init, or you can properly deregister, and that's
about it, no?
johannes
next prev parent reply other threads:[~2011-03-18 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 3:10 [RTF] iwmc3200wifi: fix device registration ordering for cfg80211 Luis R. Rodriguez
2011-03-18 3:11 ` Luis R. Rodriguez
2011-03-18 13:50 ` John W. Linville
2011-03-18 16:05 ` Luis R. Rodriguez
2011-03-18 17:41 ` Luis R. Rodriguez
2011-03-18 18:03 ` Johannes Berg [this message]
2011-03-18 18:05 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a86de09887dbbf9a5e6d1d1018521a5d@secure.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=naveen.singh@atheros.com \
--cc=stable@kernel.org \
--cc=vmehta@atheros.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).