From: Johannes Berg <johannes@sipsolutions.net>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org,
Stanislav Yakovlev <stas.yakovlev@gmail.com>
Subject: Re: [PATCH 1/3] wifi: ipw2x00: convert ipw_fw_error->elem to flexible array[]
Date: Tue, 28 Feb 2023 18:16:07 +0100 [thread overview]
Message-ID: <a8798dce4ae87aee64dfd56721b1668f8c969951.camel@sipsolutions.net> (raw)
In-Reply-To: <20230228162827.3876606-1-jacob.e.keller@intel.com>
On Tue, 2023-02-28 at 08:28 -0800, Jacob Keller wrote:
>
> @@ -1247,7 +1247,6 @@ static struct ipw_fw_error *ipw_alloc_error_log(struct ipw_priv *priv)
> error->config = priv->config;
> error->elem_len = elem_len;
> error->log_len = log_len;
> - error->elem = (struct ipw_error_elem *)error->payload;
> error->log = (struct ipw_event *)(error->elem + elem_len);
I really don't know this driver, it's ancient, but that last line looks
wrong to me already, elem_len doesn't seem like # of elems?
But I guess this patch changes nothing here, so hey. Don't think there's
much value in the change either, this driver isn't going to get touched
any more, just removed eventually ;)
johannes
next prev parent reply other threads:[~2023-02-28 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 16:28 [PATCH 1/3] wifi: ipw2x00: convert ipw_fw_error->elem to flexible array[] Jacob Keller
2023-02-28 16:28 ` [PATCH 2/3] wifi: cfg80211: use struct_size and size_sub for payload length Jacob Keller
2023-02-28 17:16 ` Johannes Berg
2023-02-28 16:28 ` [PATCH 3/3] wifi: nl80211: convert cfg80211_scan_request allocation to *_size macros Jacob Keller
2023-02-28 17:16 ` Johannes Berg [this message]
2023-02-28 17:44 ` [PATCH 1/3] wifi: ipw2x00: convert ipw_fw_error->elem to flexible array[] Jacob Keller
2023-02-28 17:46 ` Johannes Berg
2023-02-28 17:48 ` Jacob Keller
2023-03-01 20:49 ` Jacob Keller
2023-03-01 20:53 ` Johannes Berg
2023-03-01 21:01 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8798dce4ae87aee64dfd56721b1668f8c969951.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jacob.e.keller@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox