From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH rtw-next] wifi: rtw88: Lock rtwdev->mutex before setting the LED
Date: Mon, 4 Aug 2025 01:51:17 +0000 [thread overview]
Message-ID: <a8bc1e18ccec418b9fe64b14b5f5c23f@realtek.com> (raw)
In-Reply-To: <ed69fa07-8678-4a40-af44-65e7b1862197@gmail.com>
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> Some users report that the LED blinking breaks AP mode somehow. Most
> likely the LED code and the dynamic mechanism are trying to access the
> hardware registers at the same time. Fix it by locking rtwdev->mutex
> before setting the LED and unlocking it after.
>
> Fixes: 4b6652bc6d8d ("wifi: rtw88: Add support for LED blinking")
> Link: https://github.com/lwfinger/rtw88/issues/305
I'd change Link to "Closes:" during merging this patch.
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2025-08-04 1:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 20:08 [PATCH rtw-next] wifi: rtw88: Lock rtwdev->mutex before setting the LED Bitterblue Smith
2025-08-01 20:39 ` [PATCH rtw-next 07/11] wifi: rtw89: Add rtw8852c_dle_mem_usb{2,3} Bitterblue Smith
2025-08-04 1:51 ` Ping-Ke Shih [this message]
2025-08-12 8:11 ` [PATCH rtw-next] wifi: rtw88: Lock rtwdev->mutex before setting the LED Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8bc1e18ccec418b9fe64b14b5f5c23f@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox