From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A10AC3A5A2 for ; Fri, 23 Aug 2019 10:54:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F41B21726 for ; Fri, 23 Aug 2019 10:54:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732457AbfHWKyt (ORCPT ); Fri, 23 Aug 2019 06:54:49 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:57186 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731280AbfHWKyt (ORCPT ); Fri, 23 Aug 2019 06:54:49 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i17DQ-00023m-8j; Fri, 23 Aug 2019 12:54:44 +0200 Message-ID: Subject: Re: Implementing Mikrotik IE From: Johannes Berg To: Josef Miegl Cc: Sebastian Gottschall , linux-wireless Date: Fri, 23 Aug 2019 12:54:42 +0200 In-Reply-To: <68A3B9AF-8864-4C0F-A50B-71CCB76AE81D@miegl.cz> References: <20190815152844.k5mmddvbwrohkzr6@pepin-laptop.localdomain> <3a079683-6f57-3b42-f909-90c46e14f14f@newmedia-net.de> <20190816111044.4ntizgmpa3twbzcg@pepin-laptop.localdomain> <20190816113818.ohktykc4fyetzyvq@pepin-laptop.localdomain> <9985fddfb059640f36665efc9c1ef2dc0bdb7662.camel@sipsolutions.net> <20190819113706.ujsz67sxcwt2ulmt@pepin-laptop.localdomain> <6efb9b56c77cd9ea945f89c3371b49c301dc2b4e.camel@sipsolutions.net> <58A25955-2A17-4DE7-82FB-3B20E00C96EC@miegl.cz> <5ee160209eb1f9e70f6224c393389266280d7d80.camel@sipsolutions.net> (sfid-20190822_090033_537095_4B41631C) <0452a0cbb36bcffa8371a58dfd931864c1f79eef.camel@sipsolutions.net> <68A3B9AF-8864-4C0F-A50B-71CCB76AE81D@miegl.cz> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > Works great. Is there a possibility that a toggle for this could be > accepted upstream? After all, WDS isn't really standardized. I general, I'd say yes. However! There's ongoing to work to make EAPOL frames go over nl80211 instead, see e.g. ieee80211_tx_control_port() in mac80211, and this patch for hostapd: https://patchwork.ozlabs.org/patch/1108185/ I'd prefer to have it in this path, by having a flag like the "bool unencrypted" passed to ieee80211_tx_control_port(), (and replace "bool unencrypted" by "unsigned int flags"). That way, we don't have to actually keep any state. In mac80211, we can pass this down to __ieee80211_subif_start_xmit() and ieee80211_build_hdr() in the ctrl_flags or something like that. It doesn't actually need to be a control or info flag, so we could add yet another argument to save the space, but dunno if that's worth it now. johannes