RE: [PATCH rtw-next v2] wifi: rtw89: set RA init rate level from RSSI in RA update

[Ping-Ke Shih <pkshih@realtek.com>]

Vincent Schurink <spam@acio.nl> wrote:
> When a station associates to an AP, the AP does not know the RSSI of
> the station yet. Thus, rtw89_phy_ra_assoc() sends init_rate_lv 0 to the
> firmware. With this value, the firmware RA of RTL8922A uses 20 MHz and
> VHT-MCS 2 for the station. The firmware RA does not try a higher rate,
> also when the PER is 0. On an 80 MHz AP, the TCP throughput to the
> station stays at approximately 35 Mbit/s.

As rtw89_phy_ra_sta_update() does below periodically to update rate mask.

    ra_mask &= rtw89_phy_ra_mask_rssi(rtwdev, rssi, 0);

Could you try moving AP and station closer to see if this can improve?
(Please run over 1 minute to have enough time for the RA algorithm.)

> 
> Move the mapping from RSSI to init_rate_lv to a function, and use it in
> the RA association and in the RA update. The firmware uses
> init_rate_lv only together with upd_all. Thus, the RA update also sets
> upd_all one time, when the level changes from 0 to a known level.

The upd_all will reset RA context, so only do this once if RSSI is unknown
during association like your v1.

[...]

> @@ -509,6 +523,7 @@ void rtw89_phy_ra_update_sta_link(struct rtw89_dev *rtwdev,
>         struct rtw89_vif_link *rtwvif_link = rtwsta_link->rtwvif_link;
>         struct ieee80211_vif *vif = rtwvif_link_to_vif(rtwvif_link);
>         struct rtw89_ra_info *ra = &rtwsta_link->ra;
> +       u8 prev_lv = ra->init_rate_lv;
>         struct ieee80211_link_sta *link_sta;

reverse X'mas tree order.

> 
>         rcu_read_lock();
> @@ -519,6 +534,9 @@ void rtw89_phy_ra_update_sta_link(struct rtw89_dev *rtwdev,
> 
>         rcu_read_unlock();
> 
> +       ra->init_rate_lv = rtw89_phy_ra_get_init_rate_lv(rtwsta_link);
> +       if (!prev_lv && ra->init_rate_lv)
> +               ra->upd_all = 1;

As I mentioned above.

>         if (changed & IEEE80211_RC_SUPP_RATES_CHANGED)
>                 ra->upd_mask = 1;
>         if (changed & (IEEE80211_RC_BW_CHANGED | IEEE80211_RC_NSS_CHANGED))