Linux wireless drivers development
 help / color / mirror / Atom feed
From: Lingbo Kong <quic_lingbok@quicinc.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	Benjamin Berg <benjamin@sipsolutions.net>,
	<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: cfg80211: Correctly handle Medium Synchronization Delay
Date: Thu, 31 Oct 2024 18:51:48 +0800	[thread overview]
Message-ID: <a921cfb6-3877-4364-9c55-cc89c3d97535@quicinc.com> (raw)
In-Reply-To: <f6ec91977050f6a1f08d995b4e36ef4067ad3de2.camel@sipsolutions.net>



On 2024/10/31 18:47, Johannes Berg wrote:
> On Thu, 2024-10-31 at 10:25 +0100, Benjamin Berg wrote:
>>
>> Right, which does seem to imply that a non-NSTR AP can very well set a
>> Medium Delay Synchronization.
> 
> Yes, we also pass it to the firmware in iwlwifi, so definitely.
> 
>>> Regarding the statement “Could it be that this is intended to be used by
>>> NSTR APs only,” I did not find any explicit indication in the spec that
>>> the multi-link probe response carrying the medium sync delay subfield is
>>> solely applicable to NSTR APs.
>>>
>>> Additionally, do you have any suggestions on how to address this issue?🙂
>>
>> Not really. I don't grasp the intention of the specification here. But
>> if an AP may include the field in an ML Probe Response, then we
>> obviously cannot rely on the value to be consistent.
>>
>> Seems to me that the option to remove the check is still the best way
>> forward right now.
> 
> Agree, let's just remove it - Lingbo do you want to send a patch?
> 
> We should probably compare "extended MLD capabilities and ops" though,
> haha.
> 
> johannes

hi, johannes,

I completely agree with your perspective. I will resend a revised patch 
that removes this validity check.🙂

/lingbok

      reply	other threads:[~2024-10-31 10:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30  2:55 [PATCH] wifi: cfg80211: Correctly handle Medium Synchronization Delay Lingbo Kong
2024-10-30 10:23 ` Benjamin Berg
2024-10-31  5:23   ` Lingbo Kong
2024-10-31  9:25     ` Benjamin Berg
2024-10-31 10:47       ` Johannes Berg
2024-10-31 10:51         ` Lingbo Kong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a921cfb6-3877-4364-9c55-cc89c3d97535@quicinc.com \
    --to=quic_lingbok@quicinc.com \
    --cc=ath12k@lists.infradead.org \
    --cc=benjamin@sipsolutions.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox