From: Ping-Ke Shih <pkshih@realtek.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Kalle Valo <kvalo@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 2/2] wifi: rtlwifi: simplify TX command fill callbacks
Date: Fri, 13 Oct 2023 09:17:08 +0000 [thread overview]
Message-ID: <a926eb507bf447c39fc9fc01d41abd97@realtek.com> (raw)
In-Reply-To: <20231011154442.52457-2-dmantipov@yandex.ru>
> -----Original Message-----
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Sent: Wednesday, October 11, 2023 11:45 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org; Dmitry Antipov <dmantipov@yandex.ru>
> Subject: [PATCH 2/2] wifi: rtlwifi: simplify TX command fill callbacks
>
> Since 'rtlpriv->cfg->ops->fill_tx_cmddesc()' is always called
> with 'firstseg' and 'lastseg' set to 1 (and the latter is
The 'firstseg' is used to optimize the code if more than one segments.
However, I think rtlwifi will not support multiple segments in the future,
so changes in this patch would be fine.
> never actually used), all of the relevant chip-specific
> routines may be simplified. Compile tested only.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2023-10-13 9:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 15:44 [PATCH 1/2] wifi: rtlwifi: cleanup struct rtl_ps_ctl Dmitry Antipov
2023-10-11 15:44 ` [PATCH 2/2] wifi: rtlwifi: simplify TX command fill callbacks Dmitry Antipov
2023-10-13 9:17 ` Ping-Ke Shih [this message]
2023-10-14 6:42 ` Kalle Valo
2023-10-13 8:11 ` [PATCH 1/2] wifi: rtlwifi: cleanup struct rtl_ps_ctl Ping-Ke Shih
2023-10-13 12:45 ` [PATCH] [v2] " Dmitry Antipov
2023-10-16 5:38 ` Ping-Ke Shih
2023-10-19 7:27 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a926eb507bf447c39fc9fc01d41abd97@realtek.com \
--to=pkshih@realtek.com \
--cc=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).