From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-wireless-owner@vger.kernel.org
Subject: Re: [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling
Date: Mon, 01 Oct 2018 22:20:27 -0700 [thread overview]
Message-ID: <a944f87d1d94fd246f309cc62680a04b@codeaurora.org> (raw)
In-Reply-To: <87k1n4botm.fsf@toke.dk>
On 2018-09-29 03:06, Toke Høiland-Jørgensen wrote:
> Rajkumar Manoharan <rmanohar@codeaurora.org> writes:
>
>> - ath10k_htt_tx_txq_update(hw, f_txq);
>> + if (ret == -EBUSY) {
>> + ieee80211_txq_schedule_start(hw, ac);
>> + ieee80211_return_txq(hw, txq);
>> + ieee80211_txq_schedule_end(hw, ac);
>> + }
>
> And ieee80211_return_txq() should be called regardless of the return
> code (it'll do it's own checking and do nothing if the queue is empty).
>
Yeah.. Seems like calling return_txq unconditionally is messing with
may_transmit sequence. i.e pull mode.
-Rajkumar
next prev parent reply other threads:[~2018-10-02 5:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 23:16 [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling Rajkumar Manoharan
2018-09-28 23:16 ` [RFC v2 2/2] ath10k: reporting estimated tx airtime for fairness Rajkumar Manoharan
2018-09-29 10:06 ` [RFC v2 1/2] ath10k: migrate to mac80211 txq scheduling Toke Høiland-Jørgensen
2018-10-02 5:20 ` Rajkumar Manoharan [this message]
2018-10-02 10:51 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a944f87d1d94fd246f309cc62680a04b@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).