From: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v7 7/9] wifi: ath12k: fix NULL access in assign channel context handler
Date: Sat, 22 Feb 2025 11:51:22 +0530 [thread overview]
Message-ID: <a9f4e06a-1d77-5ab8-83a2-59e2920d8dc1@oss.qualcomm.com> (raw)
In-Reply-To: <20250222033002.3886215-8-quic_periyasa@quicinc.com>
On 2/22/2025 9:00 AM, Karthikeyan Periyasamy wrote:
> Currently, when ath12k_mac_assign_vif_to_vdev() fails, the radio handle
> (ar) gets accessed fom the link VIF handle (arvif) for debug logging, This
> is incorrect. In the fail scenario, radio handle is NULL. Fix the NULL
> access, avoid radio handle access by moving to the hardware debug logging
> helper function (ath12k_hw_warn).
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Fixes: 90570ba4610b ("wifi: ath12k: do not return invalid link id for scan link")
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
next prev parent reply other threads:[~2025-02-22 6:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-22 3:29 [PATCH v7 0/9] wifi: ath12k: Add monitor interface support on QCN9274 Karthikeyan Periyasamy
2025-02-22 3:29 ` [PATCH v7 1/9] wifi: ath12k: fix link valid field initialization in the monitor Rx Karthikeyan Periyasamy
2025-02-22 3:29 ` [PATCH v7 2/9] wifi: ath12k: Add extra TLV tag parsing support in monitor Rx path Karthikeyan Periyasamy
2025-02-22 3:29 ` [PATCH v7 3/9] wifi: ath12k: Avoid fetch Error bitmap and decap format from Rx TLV Karthikeyan Periyasamy
2025-02-22 3:29 ` [PATCH v7 4/9] wifi: ath12k: Replace band define G with GHZ where appropriate Karthikeyan Periyasamy
2025-02-22 3:29 ` [PATCH v7 5/9] wifi: ath12k: change the status update in the monitor Rx Karthikeyan Periyasamy
2025-02-22 3:29 ` [PATCH v7 6/9] wifi: ath12k: Avoid packet offset and FCS length from Rx TLV Karthikeyan Periyasamy
2025-02-22 3:30 ` [PATCH v7 7/9] wifi: ath12k: fix NULL access in assign channel context handler Karthikeyan Periyasamy
2025-02-22 6:21 ` Vasanthakumar Thiagarajan [this message]
2025-02-22 3:30 ` [PATCH v7 8/9] wifi: ath12k: Refactor the monitor channel context procedure Karthikeyan Periyasamy
2025-02-22 6:23 ` Vasanthakumar Thiagarajan
2025-02-22 3:30 ` [PATCH v7 9/9] wifi: ath12k: add monitor interface support on QCN9274 Karthikeyan Periyasamy
2025-02-22 14:14 ` Vasanthakumar Thiagarajan
2025-02-22 14:50 ` Karthikeyan Periyasamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9f4e06a-1d77-5ab8-83a2-59e2920d8dc1@oss.qualcomm.com \
--to=vasanthakumar.thiagarajan@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox