From: Dan Carpenter <dan.carpenter@linaro.org>
To: Qianfeng Rong <rongqianfeng@vivo.com>
Cc: Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
Johannes Berg <johannes.berg@intel.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Kalle Valo <kvalo@kernel.org>,
Aditya Kumar Singh <quic_adisi@quicinc.com>,
Rameshkumar Sundaram <quic_ramess@quicinc.com>,
Roopni Devanathan <quic_rdevanat@quicinc.com>,
"open list:MARVELL MWIFIEX WIRELESS DRIVER"
<linux-wireless@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] wifi: mwifiex: use vmalloc_array() to simplify code
Date: Wed, 13 Aug 2025 12:25:27 +0300 [thread overview]
Message-ID: <aJxaBzZYr4d5-XUv@stanley.mountain> (raw)
In-Reply-To: <c330d0f3-d3cd-4981-8bb5-3ff5761647dc@vivo.com>
On Wed, Aug 13, 2025 at 02:52:51PM +0800, Qianfeng Rong wrote:
> >
> > I really think we should zero this memory, so lets allocate it
> > with kcalloc().
> I agree with you, I will try to do this in the next version.
Thanks. When you resend it make sure to add a Fixes tag and CC stable.
Forgetting to zero the memory is a sort of security issue.
regards,
dan carpenter
next prev parent reply other threads:[~2025-08-13 14:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 13:32 [PATCH 0/5] net: use vmalloc_array() to simplify code Qianfeng Rong
2025-08-12 13:32 ` [PATCH 4/5] wifi: ath5k: " Qianfeng Rong
2025-08-12 13:32 ` [PATCH 5/5] wifi: mwifiex: " Qianfeng Rong
2025-08-12 13:48 ` Dan Carpenter
2025-08-12 14:13 ` Qianfeng Rong
2025-08-12 14:31 ` Dan Carpenter
2025-08-13 6:52 ` Qianfeng Rong
2025-08-13 9:25 ` Dan Carpenter [this message]
2025-08-13 18:35 ` Jeff Johnson
2025-08-14 6:24 ` Dan Carpenter
2025-08-12 20:48 ` [PATCH 0/5] net: " Jakub Kicinski
2025-08-13 1:53 ` Qianfeng Rong
2025-08-13 6:49 ` Qianfeng Rong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJxaBzZYr4d5-XUv@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_adisi@quicinc.com \
--cc=quic_ramess@quicinc.com \
--cc=quic_rdevanat@quicinc.com \
--cc=rongqianfeng@vivo.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox