From: Lennert Buytenhek <buytenh@wantstofly.org>
To: Pawel Dembicki <paweldembicki@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Antony Kolitsos <zeusomighty@hotmail.com>,
Johannes Berg <johannes.berg@intel.com>,
Roopni Devanathan <quic_rdevanat@quicinc.com>,
Thomas Fourier <fourier.thomas@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] wifi: mwl8k: inject DSSS Parameter Set element into beacons if missing
Date: Tue, 11 Nov 2025 18:06:17 +0200 [thread overview]
Message-ID: <aRNe-VdyGrvumVok@wantstofly.org> (raw)
In-Reply-To: <20251111100733.2825970-3-paweldembicki@gmail.com>
On Tue, Nov 11, 2025 at 11:07:29AM +0100, Pawel Dembicki wrote:
> Some Marvell AP firmware used with mwl8k misbehaves when beacon frames
> do not contain a WLAN_EID_DS_PARAMS element with the current channel.
> It was reported on OpenWrt Github issues [0].
>
> When hostapd/mac80211 omits DSSS Parameter Set from the beacon (which is
> valid on some bands), the firmware stops transmitting sane frames and RX
> status starts reporting bogus channel information. This makes AP mode
> unusable.
>
> Newer Marvell drivers (mwlwifi [1]) hard-code DSSS Parameter Set into
> AP beacons for all chips, which suggests this is a firmware requirement
> rather than a mwl8k-specific quirk.
>
> Mirror that behaviour in mwl8k: when setting the beacon, check if
> WLAN_EID_DS_PARAMS is present, and if not, extend the beacon and inject
> a DSSS Parameter Set element, using the current channel from
> hw->conf.chandef.chan.
>
> Tested on Linksys EA4500 (88W8366).
Given that I was CCd on this email -- I no longer have the hardware to
test this, but I can believe that the firmware would have such an issue,
and you seem to know what you are doing, so this seems conceptually OK
to me, for whatever that is worth.
prev parent reply other threads:[~2025-11-11 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 10:07 [PATCH v4] wifi: mwl8k: inject DSSS Parameter Set element into beacons if missing Pawel Dembicki
2025-11-11 16:06 ` Lennert Buytenhek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRNe-VdyGrvumVok@wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=fourier.thomas@gmail.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=paweldembicki@gmail.com \
--cc=quic_rdevanat@quicinc.com \
--cc=zeusomighty@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox