iwlwifi: WARNING at iwl_mvm_ptp_init / ptp_clock_register

iwlwifi: WARNING at iwl_mvm_ptp_init / ptp_clock_register

[Chris Bainbridge]

A new warning has recently appeared due to commit:

commit dfb073d32cac28cdb597d16d1e0589b25c841661
Author: Tim Hostetler <thostet@google.com>
Date:   Tue Nov 4 14:59:15 2025 -0800

    ptp: Return -EINVAL on ptp_clock_register if required ops are NULL

    ptp_clock should never be registered unless it stubs one of gettimex64()
    or gettime64() and settime64(). WARN_ON_ONCE and error out if either set
    of function pointers is null.

    For consistency, n_alarm validation is also folded into the
    WARN_ON_ONCE.


Log:

[   18.420114] ------------[ cut here ]------------
[   18.420121] WARNING: drivers/ptp/ptp_clock.c:325 at ptp_clock_register+0x129/0x7f0, CPU#14: NetworkManager/1568
[   18.420127] Modules linked in: qrtr rfcomm cmac algif_hash algif_skcipher af_alg bnep binfmt_misc ext4 mbcache jbd2 nls_ascii nls_cp437 vfat fat iwlmvm snd_hda_codec_generic snd_hda_codec_hdmi intel_rapl_msr amd_atl mac80211 intel_rapl_common snd_hda_intel libarc4 btusb uvcvideo snd_hda_codec btrtl videobuf2_vmalloc btintel snd_intel_dspcfg videobuf2_memops btbcm snd_hwdep kvm_amd uvc btmtk videobuf2_v4l2 iwlwifi snd_hda_core snd_hda_scodec_cs35l41_i2c bluetooth videodev snd_pcm kvm snd_hda_scodec_cs35l41 cfg80211 snd_soc_cs_amp_lib videobuf2_common snd_timer cs_dsp ideapad_laptop irqbypass ecdh_generic ecc sparse_keymap rapl mc wmi_bmof platform_profile ee1004 snd_soc_cs35l41_lib pcspkr snd k10temp ccp battery rfkill sg soundcore cm32181 industrialio serial_multi_instantiate ac joydev evdev msr parport_pc ppdev lp parport nvme_fabrics fuse efi_pstore configfs nfnetlink efivarfs autofs4 crc32c_cryptoapi btrfs blake2b libblake2b xor raid6_pq dm_crypt sd_mod uas usbhid usb_storage amdgpu nouveau drm_gpuvm mxm_wmi
[   18.420214]  drm_client_lib i2c_algo_bit sp5100_tco dm_mod drm_suballoc_helper drm_ttm_helper drm_buddy ahci i2c_piix4 ttm drm_panel_backlight_quirks drm_exec libahci gpu_sched amdxcp r8169 ucsi_acpi libata hid_multitouch drm_display_helper typec_ucsi realtek hid_generic scsi_mod drm_kms_helper roles xhci_pci wdat_wdt mdio_devres xhci_hcd typec video nvme ghash_clmulni_intel cec serio_raw scsi_common watchdog i2c_hid_acpi crc16 i2c_smbus libphy usbcore thunderbolt mdio_bus nvme_core rc_core i2c_hid usb_common hid wmi drm button aesni_intel
[   18.420260] CPU: 14 UID: 0 PID: 1568 Comm: NetworkManager Not tainted 6.18.0-12692-gcb015814f8b6 #224 PREEMPT(voluntary)
[   18.420262] Hardware name: LENOVO 82N6/LNVNB161216, BIOS GKCN65WW 01/16/2024
[   18.420264] RIP: 0010:ptp_clock_register+0x129/0x7f0
[   18.420267] Code: c7 40 76 a8 87 41 89 c4 e8 e4 ff 32 00 45 85 e4 74 4c 49 63 ec 4c 89 ff e8 a4 88 a2 ff eb 14 48 83 7f 78 00 0f 85 41 ff ff ff <0f> 0b 48 c7 c5 ea ff ff ff 48 8b 84 24 88 00 00 00 65 48 2b 05 4e
[   18.420268] RSP: 0018:ffffb84b805473f0 EFLAGS: 00010246
[   18.420271] RAX: 0000000000000000 RBX: ffff9e8e49625de8 RCX: ffffb84b80547404
[   18.420272] RDX: 0000000000000003 RSI: ffff9e8e42cc30c8 RDI: ffff9e8e49625de8
[   18.420273] RBP: ffff9e8e42cc30c8 R08: 0000000000000001 R09: ffffffff8780d200
[   18.420274] R10: 000000000000092c R11: 0000000000000003 R12: ffff9e8e496230e8
[   18.420276] R13: 000000000f700000 R14: ffff9e8e496230e8 R15: ffff9e8e49623118
[   18.420277] FS:  00007f7cfe3d3580(0000) GS:ffff9e94c9e82000(0000) knlGS:0000000000000000
[   18.420278] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   18.420280] CR2: 00000000169d40c8 CR3: 000000010f5e1000 CR4: 0000000000750ef0
[   18.420281] PKRU: 55555554
[   18.420282] Call Trace:
[   18.420284]  <TASK>
[   18.420285]  ? lock_release+0x17b/0x2a0
[   18.420291]  ? queue_work_node+0x150/0x150
[   18.420294]  ? is_module_address+0x6a/0xf0
[   18.420297]  ? static_obj+0x67/0x90
[   18.420299]  ? lockdep_init_map_type+0x58/0x240
[   18.420304]  iwl_mvm_ptp_init+0x102/0x150 [iwlmvm]
[   18.420315]  iwl_mvm_up+0x874/0x910 [iwlmvm]
[   18.420323]  ? __mutex_lock+0x288/0x1090
[   18.420329]  ? lock_is_held_type+0xd5/0x130
[   18.420333]  __iwl_mvm_mac_start+0x82/0x2c0 [iwlmvm]
[   18.420341]  iwl_mvm_mac_start+0x4b/0xe0 [iwlmvm]
[   18.420348]  drv_start+0x6f/0x1a0 [mac80211]
[   18.420378]  ieee80211_do_open+0x2d3/0x920 [mac80211]
[   18.420403]  ieee80211_open+0x8a/0x90 [mac80211]
[   18.420422]  __dev_open+0x118/0x270
[   18.420427]  __dev_change_flags+0x21a/0x250
[   18.420432]  netif_change_flags+0x22/0x60
[   18.420435]  do_setlink.isra.0+0x34f/0x1190
[   18.420438]  ? lock_acquire+0xe1/0x2d0
[   18.420443]  ? rcu_is_watching+0xd/0x40
[   18.420446]  ? __mutex_lock+0x288/0x1090
[   18.420447]  ? __nla_validate_parse+0x5e/0xb60
[   18.420451]  ? rtnl_newlink+0x381/0xb90
[   18.420458]  rtnl_newlink+0x853/0xb90
[   18.420463]  ? __lock_acquire+0x459/0x2170
[   18.420470]  ? find_held_lock+0x2b/0x80
[   18.420472]  ? rtnetlink_rcv_msg+0x3e6/0x660
[   18.420474]  ? rtnetlink_rcv_msg+0x3e6/0x660
[   18.420477]  ? lock_release+0x17b/0x2a0
[   18.420479]  ? do_setlink.isra.0+0x1190/0x1190
[   18.420482]  rtnetlink_rcv_msg+0x405/0x660
[   18.420488]  ? rtnl_fdb_dump+0x230/0x230
[   18.420491]  netlink_rcv_skb+0x4b/0xf0
[   18.420499]  netlink_unicast+0x1f5/0x2d0
[   18.420501]  ? __virt_addr_valid+0x112/0x2e0
[   18.420506]  netlink_sendmsg+0x216/0x450
[   18.420511]  __sock_sendmsg+0x38/0x70
[   18.420515]  ____sys_sendmsg+0x23f/0x290
[   18.420517]  ? import_iovec+0x2b/0x30
[   18.420522]  ___sys_sendmsg+0x99/0xe0
[   18.420534]  ? __fget_files+0xc3/0x180
[   18.420538]  __sys_sendmsg+0x84/0xe0
[   18.420546]  do_syscall_64+0x95/0x7d0
[   18.420548]  ? do_syscall_64+0x1dc/0x7d0
[   18.420550]  ? fput+0x3b/0x90
[   18.420553]  ? entry_SYSCALL_64_after_hwframe+0x4b/0x53
[   18.420555]  ? lockdep_hardirqs_on+0x78/0x100
[   18.420558]  ? do_syscall_64+0x1dc/0x7d0
[   18.420560]  ? lockdep_hardirqs_on_prepare+0xce/0x190
[   18.420562]  ? irqentry_exit+0xec/0x660
[   18.420566]  entry_SYSCALL_64_after_hwframe+0x4b/0x53
[   18.420567] RIP: 0033:0x7f7cff6a49ee
[   18.420570] Code: 08 0f 85 f5 4b ff ff 49 89 fb 48 89 f0 48 89 d7 48 89 ce 4c 89 c2 4d 89 ca 4c 8b 44 24 08 4c 8b 4c 24 10 4c 89 5c 24 08 0f 05 <c3> 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 80 00 00 00 00 48 83 ec 08
[   18.420571] RSP: 002b:00007ffc0321c9b8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
[   18.420574] RAX: ffffffffffffffda RBX: 00007f7cfe3d3580 RCX: 00007f7cff6a49ee
[   18.420575] RDX: 0000000000000000 RSI: 00007ffc0321ca40 RDI: 000000000000000d
[   18.420576] RBP: 00007ffc0321ca40 R08: 0000000000000000 R09: 0000000000000000
[   18.420577] R10: 0000000000000000 R11: 0000000000000246 R12: 000000000000001a
[   18.420578] R13: 00007ffc0321cc38 R14: 00007ffc0321cc2c R15: 0000000000000000
[   18.420586]  </TASK>
[   18.420587] irq event stamp: 112525
[   18.420588] hardirqs last  enabled at (112531): [<ffffffff8659c93e>] __up_console_sem+0x5e/0x70
[   18.420591] hardirqs last disabled at (112536): [<ffffffff8659c923>] __up_console_sem+0x43/0x70
[   18.420593] softirqs last  enabled at (111048): [<ffffffff86e5abba>] __alloc_skb+0x18a/0x1f0
[   18.420595] softirqs last disabled at (111046): [<ffffffff86e5abba>] __alloc_skb+0x18a/0x1f0
[   18.420597] ---[ end trace 0000000000000000 ]---