From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jeff Chen <jeff.chen_1@nxp.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
briannorris@chromium.org, johannes@sipsolutions.net,
francesco@dolcini.it, tsung-hsien.hsieh@nxp.com
Subject: Re: [PATCH v8 12/22] wifi: nxpwifi: introduce command and event handling infrastructure
Date: Fri, 5 Dec 2025 08:11:12 +0100 [thread overview]
Message-ID: <aTKFkOPTgrbZEPRn@pengutronix.de> (raw)
In-Reply-To: <20251205065545.3325032-13-jeff.chen_1@nxp.com>
Hi Jeff,
On Fri, Dec 05, 2025 at 02:55:35PM +0800, Jeff Chen wrote:
> +
> + /* Check init command response */
> + if (adapter->hw_status == NXPWIFI_HW_STATUS_INITIALIZING) {
> + if (ret) {
> + nxpwifi_dbg(adapter, ERROR,
> + "%s: cmd %#x failed during\t"
> + "initialization\n", __func__, cmdresp_no);
> + nxpwifi_init_fw_complete(adapter);
> + return ret;
> + } else if (adapter->last_init_cmd == cmdresp_no) {
> + adapter->hw_status = NXPWIFI_HW_STATUS_INIT_DONE;
> + }
> + }
As said before, please drop this asynchronous initialization stuff.
A patch doing this for the mxiwiex driver is here:
https://lore.kernel.org/all/20241202-mwifiex-cleanup-1-v3-12-317a6ce0dd5b@pengutronix.de/
It will apply nearly as-is to the nxpwifi driver and it's much easier to
do this before it hits mainline.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-12-05 7:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 6:55 [PATCH v8 00/22] wifi: nxpwifi: create nxpwifi to support Jeff Chen
2025-12-05 6:55 ` [PATCH v8 01/22] wifi: nxpwifi: Add 802.11n support for client and AP modes Jeff Chen
2025-12-05 6:55 ` [PATCH v8 02/22] wifi: nxpwifi: add initial support for 802.11ac Jeff Chen
2025-12-05 6:55 ` [PATCH v8 03/22] wifi: nxpwifi: add initial support for 802.11ax Jeff Chen
2025-12-05 6:55 ` [PATCH v8 04/22] wifi: nxpwifi: add support for 802.11h (DFS and TPC) Jeff Chen
2025-12-05 6:55 ` [PATCH v8 05/22] wifi: nxpwifi: add support for WMM Jeff Chen
2025-12-05 6:55 ` [PATCH v8 06/22] wifi: nxpwifi: add scan support Jeff Chen
2025-12-05 6:55 ` [PATCH v8 07/22] wifi: nxpwifi: add join and association support Jeff Chen
2025-12-05 6:55 ` [PATCH v8 08/22] wifi: nxpwifi: add channel/frequency/power (cfp) support Jeff Chen
2025-12-05 6:55 ` [PATCH v8 09/22] wifi: nxpwifi: add configuration support Jeff Chen
2025-12-05 6:55 ` [PATCH v8 10/22] wifi: nxpwifi: implement cfg80211 ops for STA and AP modes Jeff Chen
2025-12-05 6:55 ` [PATCH v8 11/22] wifi: nxpwifi: add firmware command and TLV definitions Jeff Chen
2025-12-05 6:55 ` [PATCH v8 12/22] wifi: nxpwifi: introduce command and event handling infrastructure Jeff Chen
2025-12-05 7:11 ` Sascha Hauer [this message]
2025-12-05 8:40 ` Jeff Chen
2025-12-05 6:55 ` [PATCH v8 13/22] wifi: nxpwifi: add data path support for STA and AP modes Jeff Chen
2025-12-05 6:55 ` [PATCH v8 14/22] wifi: nxpwifi: add debugfs support for diagnostics and testing Jeff Chen
2025-12-05 6:55 ` [PATCH v8 15/22] wifi: nxpwifi: add ethtool support for Wake-on-LAN Jeff Chen
2025-12-05 6:55 ` [PATCH v8 16/22] wifi: nxpwifi: add utility and IE handling support Jeff Chen
2025-12-05 6:55 ` [PATCH v8 17/22] wifi: nxpwifi: add driver initialization and shutdown support Jeff Chen
2025-12-05 6:55 ` [PATCH v8 18/22] wifi: nxpwifi: add core driver implementation Jeff Chen
2025-12-05 6:55 ` [PATCH v8 19/22] wifi: nxpwifi: add initial SDIO bus driver support Jeff Chen
2025-12-05 7:51 ` Krzysztof Kozlowski
2025-12-05 6:55 ` [PATCH v8 20/22] wifi: nxpwifi: add NXP vendor and IW61x device IDs to sdio_ids.h Jeff Chen
2025-12-05 7:46 ` Krzysztof Kozlowski
2025-12-05 6:55 ` [PATCH v8 21/22] wifi: nxpwifi: add Kconfig and Makefile for kernel integration Jeff Chen
2025-12-05 6:55 ` [PATCH v8 22/22] wifi: nxpwifi: add MAINTAINERS entry for nxpwifi driver Jeff Chen
2025-12-16 14:52 ` [v8,00/22] wifi: nxpwifi: create nxpwifi to support Romit Chatterjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTKFkOPTgrbZEPRn@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=jeff.chen_1@nxp.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tsung-hsien.hsieh@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox