From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>
Subject: Re: [PATCH] wifi: iwlwifi: Fix firmware version handling
Date: Tue, 9 Dec 2025 10:20:50 +0200 [thread overview]
Message-ID: <aTfb4sRxlIVE9jB1@intel.com> (raw)
In-Reply-To: <20251113222852.15896-1-ville.syrjala@linux.intel.com>
On Fri, Nov 14, 2025 at 12:28:52AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> On my system the arithmetic done on the firmware numbers
> results in a negative number, but since the types are
> unsigned it gets interpreted as a large positive number.
>
> The end result is that the firmware gets rejected and wifi
> is defunct.
>
> Switch to signed types to handle this case correctly.
>
> iwlwifi 0000:0c:00.0: Driver unable to support your firmware API. Driver supports FW core 4294967294..2, firmware is 2.
> iwlwifi 0000:0c:00.0: Direct firmware load for iwlwifi-5000-4.ucode failed with error -2
> iwlwifi 0000:0c:00.0: Direct firmware load for iwlwifi-5000-3.ucode failed with error -2
> iwlwifi 0000:0c:00.0: Direct firmware load for iwlwifi-5000-2.ucode failed with error -2
> iwlwifi 0000:0c:00.0: Direct firmware load for iwlwifi-5000-1.ucode failed with error -2
> iwlwifi 0000:0c:00.0: no suitable firmware found!
> iwlwifi 0000:0c:00.0: minimum version required: iwlwifi-5000-1
> iwlwifi 0000:0c:00.0: maximum version supported: iwlwifi-5000-5
> iwlwifi 0000:0c:00.0: check git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
>
> Cc: linux-wireless@vger.kernel.org
> Cc: Johannes Berg <johannes.berg@intel.com>
> Cc: Miri Korenblit <miriam.rachel.korenblit@intel.com>
> Fixes: 5f708cccde9d ("wifi: iwlwifi: add a new FW file numbering scheme")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
This regression is now in 6.18.
Cc: stable@vger.kernel.org
> ---
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> index 607fcea6f4ef..0f002ef261fc 100644
> --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> @@ -1599,7 +1599,7 @@ static void _iwl_op_mode_stop(struct iwl_drv *drv)
> */
> static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
> {
> - unsigned int min_core, max_core, loaded_core;
> + int min_core, max_core, loaded_core;
> struct iwl_drv *drv = context;
> struct iwl_fw *fw = &drv->fw;
> const struct iwl_ucode_header *ucode;
> @@ -1678,7 +1678,7 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
> if (loaded_core < min_core || loaded_core > max_core) {
> IWL_ERR(drv,
> "Driver unable to support your firmware API. "
> - "Driver supports FW core %u..%u, firmware is %u.\n",
> + "Driver supports FW core %d..%d, firmware is %d.\n",
> min_core, max_core, loaded_core);
> goto try_again;
> }
> --
> 2.49.1
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2025-12-09 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 22:28 [PATCH] wifi: iwlwifi: Fix firmware version handling Ville Syrjala
2025-12-09 8:20 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTfb4sRxlIVE9jB1@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).