From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD0D2350A37 for ; Wed, 28 Jan 2026 12:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769604985; cv=none; b=m8czA7v/gUh2hioNyMo0p14zaIrmFB2JRsIux6p8104Ko7HRPn7YSMQpjnVK1ib9EazBbJrgFXUGclXbIDoCoDfU3MmnbJSxvljR8wrbCVL/+zNSh0YEj3mlVQhvZNgSxj75OMjX274gpbSlVsgxf/qcTwmHRBP7FvIQmo3xt/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769604985; c=relaxed/simple; bh=H4wMz2eOAnUA22tTDE7YiBFrw9e46OADbwnLFMXxEO0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YnmR+mjfKVe8zd48JCfCQ+qFu4E6kvWyF3X71OfmEBAw1s7Awa1EcCBE4fPtzPBbfbKxdShSLn1c++Tas80/xNtGHhyjLa7anBuNPWYSIO77P3oufZm+S/7sY2w6ai3Rjv1VQ/CE2jCs21KCc9UE6XOnqAEOITTPVxTWNSKaH9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=szJg0Tu7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="szJg0Tu7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 052DAC4CEF1; Wed, 28 Jan 2026 12:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769604985; bh=H4wMz2eOAnUA22tTDE7YiBFrw9e46OADbwnLFMXxEO0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=szJg0Tu7aEAsIXuqZmjwT9iKyObWKOLeGtNRMZwoMxX0ZMLKle53P58TIhFIIKyRA GhB3MV/D77gqyJDuPA0ls0gquLgQQbUFydd8gmEz6Q6wFR1GoFBl6yLeAkC0heiOII yDms8tBugAcp/68u/zb6emvWYZfcCc0jHOlGd7fWe49PTAvbMDOBa2w0CXFJA+YXaN 960sh9sOPxpOxgfkvcIa032R7+iParcfgq2hnME75CBOJSY1TuN6A8jLZY55OL8BDz YORkI6YiCSaDHooIsX23qX8IAAOgMxdPj52MYKAsyzJkB2a/Ye9iAJjTRZJCeBVT2n KCKhtMQ+MyqcA== Date: Wed, 28 Jan 2026 13:56:22 +0100 From: Lorenzo Bianconi To: Johannes Berg Cc: Ryder Lee , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, Felix Fietkau , Shayne Chen , Christian Marangi , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH wireless-next v3] wifi: mac80211: Add eMLSR/eMLMR action frame parsing support Message-ID: References: <20260128-mac80211-emlsr-v3-1-473b0c1d9cc4@kernel.org> <69d939aae0abecfdd011219e00076542c6e1abb1.camel@sipsolutions.net> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1Zs3XZ6GtgRi+Qdz" Content-Disposition: inline In-Reply-To: <69d939aae0abecfdd011219e00076542c6e1abb1.camel@sipsolutions.net> --1Zs3XZ6GtgRi+Qdz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > I probably missed this the last time already: >=20 > > + if ((control & IEEE80211_EML_CTRL_EMLSR_MODE) || > > + (control & IEEE80211_EML_CTRL_EMLMR_MODE)) { > > + eml_params.link_bitmap =3D get_unaligned_le16(ptr); > > + if (eml_params.link_bitmap && >=20 > Surely 0 is an invalid bitmap? To disable it, you send a frame without > IEEE80211_EML_CTRL_EMLSR_MODE or IEEE80211_EML_CTRL_EMLMR_MODE set, so I > don't see how an empty bitmap would be valid? ack, right. When we disable EMLSR IEEE80211_EML_CTRL_EMLSR_MODE so link_bit= map is not present. I will fix it in v4. >=20 > > + !(eml_params.link_bitmap & sdata->vif.active_links)) >=20 > That's the wrong check, I think? It only checks that you have any > overlap, but we need all bits to be valid, i.e. only >=20 > (link_bitmap & active_links) =3D=3D link_bitmap >=20 > is valid, no? ack, I will fix it in v4. >=20 > > + return; > > + } > > + > > + if (drv_set_eml_op_mode(sdata, &sta->sta, &eml_params)) > > + return; > > + > > + ieee80211_send_eml_op_mode_notif(sdata, mgmt, opt_len); >=20 > IMHO it would make more sense to pass "ptr, opt_len" rather than "mgmt, > opt_len", since that's just what gets copied and then the callee doesn't > need to dig it out. But I guess we need mgmt pointer to set even other fields (e.g. dst-addr, dialog_token, ecc.). Regards, Lorenzo >=20 > johannes --1Zs3XZ6GtgRi+Qdz Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCaXoHdgAKCRA6cBh0uS2t rIx9AQDvMwmRdK2HHZaNcr3E02VyLsA7SNysCnhg80MPCO/FTAD7BFs1g3oXdEyR 83lkQ9fbka8Lcr0RoF34SyfP3qzyoQk= =gLbO -----END PGP SIGNATURE----- --1Zs3XZ6GtgRi+Qdz--