Re: [PATCH v1] wifi: ath9k: Fix typo

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]

Hi Jeff,

On 2026-02-24T10:45:02-0800, Jeff Johnson wrote:
> On 2/23/2026 7:17 AM, Toke Høiland-Jørgensen wrote:
> > Alejandro Colomar <alx@kernel.org> writes:
> > 
> >> This only worked by chance, because all callers of this macro used the
> >> same identifiers that were expected by the macro.
> >>
> >> 	$ grep -rn ath_for_each_chanctx
> >> 	drivers/net/wireless/ath/ath9k/main.c:1576:	ath_for_each_chanctx(sc, ctx)
> >> 	drivers/net/wireless/ath/ath9k/main.c:2554:	ath_for_each_chanctx(sc, ctx) {
> >> 	drivers/net/wireless/ath/ath9k/channel.c:165:	ath_for_each_chanctx(sc, ctx) {
> >> 	drivers/net/wireless/ath/ath9k/channel.c:291:	ath_for_each_chanctx(sc, ctx) {
> >> 	drivers/net/wireless/ath/ath9k/channel.c:861:	ath_for_each_chanctx(sc, ctx) {
> >> 	drivers/net/wireless/ath/ath9k/debug.c:717:	ath_for_each_chanctx(sc, ctx) {
> >> 	drivers/net/wireless/ath/ath9k/ath9k.h:446:#define ath_for_each_chanctx(_sc, _ctx)                               \
> >>
> >> Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")
> 
> I'm dropping the Fixes tag since the existing code actually works and hence
> there is no need to backport to LTS kernels.

Sounds reasonable.  Alternatively, a line next to it saying

	[Do not backport]

would work, I guess.

Greg, I've seen this situation already a few times.  A Fixes tag getting
removed to avoid triggering a stable backport.  But I think keeping the
Fixes tag could be useful.  Should we have a standard way to document
that a patch fixes an old commit without meaning that it should be
backported?  Maybe something like this?:

	[Do not backport to stable]
	Fixes: ...

In any case, feel free to remove it.


Have a lovely night!
Alex

> 
> >> Cc: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> >> Cc: John W. Linville <linville@tuxdriver.com>
> >> Cc: Toke Høiland-Jørgensen <toke@toke.dk>
> >> Signed-off-by: Alejandro Colomar <alx@kernel.org>
> > 
> > Yeah, looks reasonable - thanks!
> > 
> > Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
> > 
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]