[PATCH v1] wifi: ath9k: Fix typo

[PATCH v1] wifi: ath9k: Fix typo

[Alejandro Colomar]

This only worked by chance, because all callers of this macro used the
same identifiers that were expected by the macro.

	$ grep -rn ath_for_each_chanctx
	drivers/net/wireless/ath/ath9k/main.c:1576:	ath_for_each_chanctx(sc, ctx)
	drivers/net/wireless/ath/ath9k/main.c:2554:	ath_for_each_chanctx(sc, ctx) {
	drivers/net/wireless/ath/ath9k/channel.c:165:	ath_for_each_chanctx(sc, ctx) {
	drivers/net/wireless/ath/ath9k/channel.c:291:	ath_for_each_chanctx(sc, ctx) {
	drivers/net/wireless/ath/ath9k/channel.c:861:	ath_for_each_chanctx(sc, ctx) {
	drivers/net/wireless/ath/ath9k/debug.c:717:	ath_for_each_chanctx(sc, ctx) {
	drivers/net/wireless/ath/ath9k/ath9k.h:446:#define ath_for_each_chanctx(_sc, _ctx)                               \

Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")
Cc: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Cc: John W. Linville <linville@tuxdriver.com>
Cc: Toke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

Hi!

I haven't build-tested the patch.  It should obviously work, but please
check.  I just realized about it while doing something else, and thought
I should send a quick fix.

Have a lovely night!
Alex


 drivers/net/wireless/ath/ath9k/ath9k.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
index 6e38aa7351e3..e8635bf81f9d 100644
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/ath/ath9k/ath9k.h
@@ -443,7 +443,7 @@ ath_node_to_tid(struct ath_node *an, u8 tidno)
 
 #define case_rtn_string(val) case val: return #val
 
-#define ath_for_each_chanctx(_sc, _ctx)                             \
+#define ath_for_each_chanctx(sc, ctx)                               \
 	for (ctx = &sc->chanctx[0];                                 \
 	     ctx <= &sc->chanctx[ARRAY_SIZE(sc->chanctx) - 1];      \
 	     ctx++)

Range-diff against v0:
-:  ------------ > 1:  6ab107cf786f wifi: ath9k: Fix typo
-- 
2.51.0

Re: [PATCH v1] wifi: ath9k: Fix typo

[Toke Høiland-Jørgensen]

Alejandro Colomar <alx@kernel.org> writes:

> This only worked by chance, because all callers of this macro used the
> same identifiers that were expected by the macro.
>
> 	$ grep -rn ath_for_each_chanctx
> 	drivers/net/wireless/ath/ath9k/main.c:1576:	ath_for_each_chanctx(sc, ctx)
> 	drivers/net/wireless/ath/ath9k/main.c:2554:	ath_for_each_chanctx(sc, ctx) {
> 	drivers/net/wireless/ath/ath9k/channel.c:165:	ath_for_each_chanctx(sc, ctx) {
> 	drivers/net/wireless/ath/ath9k/channel.c:291:	ath_for_each_chanctx(sc, ctx) {
> 	drivers/net/wireless/ath/ath9k/channel.c:861:	ath_for_each_chanctx(sc, ctx) {
> 	drivers/net/wireless/ath/ath9k/debug.c:717:	ath_for_each_chanctx(sc, ctx) {
> 	drivers/net/wireless/ath/ath9k/ath9k.h:446:#define ath_for_each_chanctx(_sc, _ctx)                               \
>
> Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")
> Cc: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> Cc: John W. Linville <linville@tuxdriver.com>
> Cc: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Alejandro Colomar <alx@kernel.org>

Yeah, looks reasonable - thanks!

Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>

Re: [PATCH v1] wifi: ath9k: Fix typo

[Jeff Johnson]

On 2/23/2026 7:17 AM, Toke Høiland-Jørgensen wrote:
> Alejandro Colomar <alx@kernel.org> writes:
> 
>> This only worked by chance, because all callers of this macro used the
>> same identifiers that were expected by the macro.
>>
>> 	$ grep -rn ath_for_each_chanctx
>> 	drivers/net/wireless/ath/ath9k/main.c:1576:	ath_for_each_chanctx(sc, ctx)
>> 	drivers/net/wireless/ath/ath9k/main.c:2554:	ath_for_each_chanctx(sc, ctx) {
>> 	drivers/net/wireless/ath/ath9k/channel.c:165:	ath_for_each_chanctx(sc, ctx) {
>> 	drivers/net/wireless/ath/ath9k/channel.c:291:	ath_for_each_chanctx(sc, ctx) {
>> 	drivers/net/wireless/ath/ath9k/channel.c:861:	ath_for_each_chanctx(sc, ctx) {
>> 	drivers/net/wireless/ath/ath9k/debug.c:717:	ath_for_each_chanctx(sc, ctx) {
>> 	drivers/net/wireless/ath/ath9k/ath9k.h:446:#define ath_for_each_chanctx(_sc, _ctx)                               \
>>
>> Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")

I'm dropping the Fixes tag since the existing code actually works and hence
there is no need to backport to LTS kernels.

>> Cc: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
>> Cc: John W. Linville <linville@tuxdriver.com>
>> Cc: Toke Høiland-Jørgensen <toke@toke.dk>
>> Signed-off-by: Alejandro Colomar <alx@kernel.org>
> 
> Yeah, looks reasonable - thanks!
> 
> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
> 

Re: [PATCH v1] wifi: ath9k: Fix typo

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]

Hi Jeff,

On 2026-02-24T10:45:02-0800, Jeff Johnson wrote:
> On 2/23/2026 7:17 AM, Toke Høiland-Jørgensen wrote:
> > Alejandro Colomar <alx@kernel.org> writes:
> > 
> >> This only worked by chance, because all callers of this macro used the
> >> same identifiers that were expected by the macro.
> >>
> >> 	$ grep -rn ath_for_each_chanctx
> >> 	drivers/net/wireless/ath/ath9k/main.c:1576:	ath_for_each_chanctx(sc, ctx)
> >> 	drivers/net/wireless/ath/ath9k/main.c:2554:	ath_for_each_chanctx(sc, ctx) {
> >> 	drivers/net/wireless/ath/ath9k/channel.c:165:	ath_for_each_chanctx(sc, ctx) {
> >> 	drivers/net/wireless/ath/ath9k/channel.c:291:	ath_for_each_chanctx(sc, ctx) {
> >> 	drivers/net/wireless/ath/ath9k/channel.c:861:	ath_for_each_chanctx(sc, ctx) {
> >> 	drivers/net/wireless/ath/ath9k/debug.c:717:	ath_for_each_chanctx(sc, ctx) {
> >> 	drivers/net/wireless/ath/ath9k/ath9k.h:446:#define ath_for_each_chanctx(_sc, _ctx)                               \
> >>
> >> Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")
> 
> I'm dropping the Fixes tag since the existing code actually works and hence
> there is no need to backport to LTS kernels.

Sounds reasonable.  Alternatively, a line next to it saying

	[Do not backport]

would work, I guess.

Greg, I've seen this situation already a few times.  A Fixes tag getting
removed to avoid triggering a stable backport.  But I think keeping the
Fixes tag could be useful.  Should we have a standard way to document
that a patch fixes an old commit without meaning that it should be
backported?  Maybe something like this?:

	[Do not backport to stable]
	Fixes: ...

In any case, feel free to remove it.


Have a lovely night!
Alex

> 
> >> Cc: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> >> Cc: John W. Linville <linville@tuxdriver.com>
> >> Cc: Toke Høiland-Jørgensen <toke@toke.dk>
> >> Signed-off-by: Alejandro Colomar <alx@kernel.org>
> > 
> > Yeah, looks reasonable - thanks!
> > 
> > Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
> > 
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v1] wifi: ath9k: Fix typo

[Jeff Johnson]

On 2/24/2026 1:27 PM, Alejandro Colomar wrote:
> Hi Jeff,
> 
> On 2026-02-24T10:45:02-0800, Jeff Johnson wrote:
>> On 2/23/2026 7:17 AM, Toke Høiland-Jørgensen wrote:
>>> Alejandro Colomar <alx@kernel.org> writes:
>>>
>>>> This only worked by chance, because all callers of this macro used the
>>>> same identifiers that were expected by the macro.
>>>>
>>>> 	$ grep -rn ath_for_each_chanctx
>>>> 	drivers/net/wireless/ath/ath9k/main.c:1576:	ath_for_each_chanctx(sc, ctx)
>>>> 	drivers/net/wireless/ath/ath9k/main.c:2554:	ath_for_each_chanctx(sc, ctx) {
>>>> 	drivers/net/wireless/ath/ath9k/channel.c:165:	ath_for_each_chanctx(sc, ctx) {
>>>> 	drivers/net/wireless/ath/ath9k/channel.c:291:	ath_for_each_chanctx(sc, ctx) {
>>>> 	drivers/net/wireless/ath/ath9k/channel.c:861:	ath_for_each_chanctx(sc, ctx) {
>>>> 	drivers/net/wireless/ath/ath9k/debug.c:717:	ath_for_each_chanctx(sc, ctx) {
>>>> 	drivers/net/wireless/ath/ath9k/ath9k.h:446:#define ath_for_each_chanctx(_sc, _ctx)                               \
>>>>
>>>> Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")
>>
>> I'm dropping the Fixes tag since the existing code actually works and hence
>> there is no need to backport to LTS kernels.
> 
> Sounds reasonable.  Alternatively, a line next to it saying
> 
> 	[Do not backport]
> 
> would work, I guess.
> 
> Greg, I've seen this situation already a few times.  A Fixes tag getting
> removed to avoid triggering a stable backport.  But I think keeping the
> Fixes tag could be useful.  Should we have a standard way to document
> that a patch fixes an old commit without meaning that it should be
> backported?  Maybe something like this?:
> 
> 	[Do not backport to stable]
> 	Fixes: ...
> 
> In any case, feel free to remove it.

Looks like we have this:
There furthermore is a variant of the stable tag you can use to make the
stable team’s backporting tools (e.g AUTOSEL or scripts that look for commits
containing a ‘Fixes:’ tag) ignore a change:
Cc: <stable+noautosel@kernel.org> # reason goes here, and must be present

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

Do you want to re-spin with that?

/jeff

Re: [PATCH v1] wifi: ath9k: Fix typo

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 2744 bytes --]

Hi Jeff,

On 2026-02-24T13:34:57-0800, Jeff Johnson wrote:
> On 2/24/2026 1:27 PM, Alejandro Colomar wrote:
> > Hi Jeff,
> > 
> > On 2026-02-24T10:45:02-0800, Jeff Johnson wrote:
> >> On 2/23/2026 7:17 AM, Toke Høiland-Jørgensen wrote:
> >>> Alejandro Colomar <alx@kernel.org> writes:
> >>>
> >>>> This only worked by chance, because all callers of this macro used the
> >>>> same identifiers that were expected by the macro.
> >>>>
> >>>> 	$ grep -rn ath_for_each_chanctx
> >>>> 	drivers/net/wireless/ath/ath9k/main.c:1576:	ath_for_each_chanctx(sc, ctx)
> >>>> 	drivers/net/wireless/ath/ath9k/main.c:2554:	ath_for_each_chanctx(sc, ctx) {
> >>>> 	drivers/net/wireless/ath/ath9k/channel.c:165:	ath_for_each_chanctx(sc, ctx) {
> >>>> 	drivers/net/wireless/ath/ath9k/channel.c:291:	ath_for_each_chanctx(sc, ctx) {
> >>>> 	drivers/net/wireless/ath/ath9k/channel.c:861:	ath_for_each_chanctx(sc, ctx) {
> >>>> 	drivers/net/wireless/ath/ath9k/debug.c:717:	ath_for_each_chanctx(sc, ctx) {
> >>>> 	drivers/net/wireless/ath/ath9k/ath9k.h:446:#define ath_for_each_chanctx(_sc, _ctx)                               \
> >>>>
> >>>> Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")
> >>
> >> I'm dropping the Fixes tag since the existing code actually works and hence
> >> there is no need to backport to LTS kernels.
> > 
> > Sounds reasonable.  Alternatively, a line next to it saying
> > 
> > 	[Do not backport]
> > 
> > would work, I guess.
> > 
> > Greg, I've seen this situation already a few times.  A Fixes tag getting
> > removed to avoid triggering a stable backport.  But I think keeping the
> > Fixes tag could be useful.  Should we have a standard way to document
> > that a patch fixes an old commit without meaning that it should be
> > backported?  Maybe something like this?:
> > 
> > 	[Do not backport to stable]
> > 	Fixes: ...
> > 
> > In any case, feel free to remove it.
> 
> Looks like we have this:
> There furthermore is a variant of the stable tag you can use to make the
> stable team’s backporting tools (e.g AUTOSEL or scripts that look for commits
> containing a ‘Fixes:’ tag) ignore a change:
> Cc: <stable+noautosel@kernel.org> # reason goes here, and must be present
> 
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1
> 
> Do you want to re-spin with that?

Would you mind amending to include the following tag?:

	Cc: <stable+noautosel@kernel.org> # the code worked by chance

I don't know where I keep the patch, so I'd have to apply it from the
email to resend.  Could you amend it yourself?


Have a lovely night!
Alex

> 
> /jeff

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v1] wifi: ath9k: Fix typo

[Jeff Johnson]

On 2/24/2026 2:55 PM, Alejandro Colomar wrote:
> Hi Jeff,
> 
> On 2026-02-24T13:34:57-0800, Jeff Johnson wrote:
>> On 2/24/2026 1:27 PM, Alejandro Colomar wrote:
>>> Hi Jeff,
>>>
>>> On 2026-02-24T10:45:02-0800, Jeff Johnson wrote:
>>>> On 2/23/2026 7:17 AM, Toke Høiland-Jørgensen wrote:
>>>>> Alejandro Colomar <alx@kernel.org> writes:
>>>>>
>>>>>> This only worked by chance, because all callers of this macro used the
>>>>>> same identifiers that were expected by the macro.
>>>>>>
>>>>>> 	$ grep -rn ath_for_each_chanctx
>>>>>> 	drivers/net/wireless/ath/ath9k/main.c:1576:	ath_for_each_chanctx(sc, ctx)
>>>>>> 	drivers/net/wireless/ath/ath9k/main.c:2554:	ath_for_each_chanctx(sc, ctx) {
>>>>>> 	drivers/net/wireless/ath/ath9k/channel.c:165:	ath_for_each_chanctx(sc, ctx) {
>>>>>> 	drivers/net/wireless/ath/ath9k/channel.c:291:	ath_for_each_chanctx(sc, ctx) {
>>>>>> 	drivers/net/wireless/ath/ath9k/channel.c:861:	ath_for_each_chanctx(sc, ctx) {
>>>>>> 	drivers/net/wireless/ath/ath9k/debug.c:717:	ath_for_each_chanctx(sc, ctx) {
>>>>>> 	drivers/net/wireless/ath/ath9k/ath9k.h:446:#define ath_for_each_chanctx(_sc, _ctx)                               \
>>>>>>
>>>>>> Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")
>>>>
>>>> I'm dropping the Fixes tag since the existing code actually works and hence
>>>> there is no need to backport to LTS kernels.
>>>
>>> Sounds reasonable.  Alternatively, a line next to it saying
>>>
>>> 	[Do not backport]
>>>
>>> would work, I guess.
>>>
>>> Greg, I've seen this situation already a few times.  A Fixes tag getting
>>> removed to avoid triggering a stable backport.  But I think keeping the
>>> Fixes tag could be useful.  Should we have a standard way to document
>>> that a patch fixes an old commit without meaning that it should be
>>> backported?  Maybe something like this?:
>>>
>>> 	[Do not backport to stable]
>>> 	Fixes: ...
>>>
>>> In any case, feel free to remove it.
>>
>> Looks like we have this:
>> There furthermore is a variant of the stable tag you can use to make the
>> stable team’s backporting tools (e.g AUTOSEL or scripts that look for commits
>> containing a ‘Fixes:’ tag) ignore a change:
>> Cc: <stable+noautosel@kernel.org> # reason goes here, and must be present
>>
>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1
>>
>> Do you want to re-spin with that?
> 
> Would you mind amending to include the following tag?:
> 
> 	Cc: <stable+noautosel@kernel.org> # the code worked by chance
> 
> I don't know where I keep the patch, so I'd have to apply it from the
> email to resend.  Could you amend it yourself?

sure, I'll amend the patch in my pending branch

/jeff

Re: [PATCH v1] wifi: ath9k: Fix typo

[Jeff Johnson]

On 2/24/2026 3:07 PM, Jeff Johnson wrote:
> On 2/24/2026 2:55 PM, Alejandro Colomar wrote:
>> Hi Jeff,
>>
>> On 2026-02-24T13:34:57-0800, Jeff Johnson wrote:
>>> On 2/24/2026 1:27 PM, Alejandro Colomar wrote:
>>>> Hi Jeff,
>>>>
>>>> On 2026-02-24T10:45:02-0800, Jeff Johnson wrote:
>>>>> On 2/23/2026 7:17 AM, Toke Høiland-Jørgensen wrote:
>>>>>> Alejandro Colomar <alx@kernel.org> writes:
>>>>>>
>>>>>>> This only worked by chance, because all callers of this macro used the
>>>>>>> same identifiers that were expected by the macro.
>>>>>>>
>>>>>>> 	$ grep -rn ath_for_each_chanctx
>>>>>>> 	drivers/net/wireless/ath/ath9k/main.c:1576:	ath_for_each_chanctx(sc, ctx)
>>>>>>> 	drivers/net/wireless/ath/ath9k/main.c:2554:	ath_for_each_chanctx(sc, ctx) {
>>>>>>> 	drivers/net/wireless/ath/ath9k/channel.c:165:	ath_for_each_chanctx(sc, ctx) {
>>>>>>> 	drivers/net/wireless/ath/ath9k/channel.c:291:	ath_for_each_chanctx(sc, ctx) {
>>>>>>> 	drivers/net/wireless/ath/ath9k/channel.c:861:	ath_for_each_chanctx(sc, ctx) {
>>>>>>> 	drivers/net/wireless/ath/ath9k/debug.c:717:	ath_for_each_chanctx(sc, ctx) {
>>>>>>> 	drivers/net/wireless/ath/ath9k/ath9k.h:446:#define ath_for_each_chanctx(_sc, _ctx)                               \
>>>>>>>
>>>>>>> Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")
>>>>>
>>>>> I'm dropping the Fixes tag since the existing code actually works and hence
>>>>> there is no need to backport to LTS kernels.
>>>>
>>>> Sounds reasonable.  Alternatively, a line next to it saying
>>>>
>>>> 	[Do not backport]
>>>>
>>>> would work, I guess.
>>>>
>>>> Greg, I've seen this situation already a few times.  A Fixes tag getting
>>>> removed to avoid triggering a stable backport.  But I think keeping the
>>>> Fixes tag could be useful.  Should we have a standard way to document
>>>> that a patch fixes an old commit without meaning that it should be
>>>> backported?  Maybe something like this?:
>>>>
>>>> 	[Do not backport to stable]
>>>> 	Fixes: ...
>>>>
>>>> In any case, feel free to remove it.
>>>
>>> Looks like we have this:
>>> There furthermore is a variant of the stable tag you can use to make the
>>> stable team’s backporting tools (e.g AUTOSEL or scripts that look for commits
>>> containing a ‘Fixes:’ tag) ignore a change:
>>> Cc: <stable+noautosel@kernel.org> # reason goes here, and must be present
>>>
>>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1
>>>
>>> Do you want to re-spin with that?
>>
>> Would you mind amending to include the following tag?:
>>
>> 	Cc: <stable+noautosel@kernel.org> # the code worked by chance
>>
>> I don't know where I keep the patch, so I'd have to apply it from the
>> email to resend.  Could you amend it yourself?
> 
> sure, I'll amend the patch in my pending branch

I've also updated the Fixes tag to meet the expected format...
Fixes: c4dc0d040e35 ("ath9k: Fetch appropriate operating channel context")

> 
> /jeff

Re: [PATCH v1] wifi: ath9k: Fix typo

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 2609 bytes --]

Hi Jeff, Greg,

On 2026-02-24T15:09:05-0800, Jeff Johnson wrote:
> >> I don't know where I keep the patch, so I'd have to apply it from the
> >> email to resend.  Could you amend it yourself?
> > 
> > sure, I'll amend the patch in my pending branch

Thanks!

> I've also updated the Fixes tag to meet the expected format...
> Fixes: c4dc0d040e35 ("ath9k: Fetch appropriate operating channel context")

Greg, I CCed you in the man-pages thread where I discussed adding the
commit date to the Fixes tags.  I was interested in your opinion, and
also think this could be useful in the kernel.

<https://lore.kernel.org/linux-man/3a656e90329f26d743d0904f56ae847951c852c7.1770150003.git.alx@kernel.org/>

Do you have any opinion about this?  Should I send a mail to some kernel
mailing list to propose its use in the kernel?

The format I used is documented in the Linux man-pages here:
<https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/patches/trailer#n16>

    Fixes
	Add 'Fixes:' tags as necessary.  'Fixes:' trailer fields should
	have the following format.

		Fixes: 12-char-hash ([author-date,] commit-date; "subject")

	where the author date is optional, and only included if it's
	somehow important.  The commit date is often more important, as
	it's sorted, and thus can be used to find (with a binary search)
	a commit whose hash and subject may have collisions.  For
	example:

		Fixes: bb509e6fcbae (2020-10-16; "kernel_lockdown.7: New page documenting the Kernel Lockdown feature")

	See <CONTRIBUTING.d/git> for how to configure the alias.ref and
	alias.ref2 git aliases.  The commit references can be produced
	with them.

		$ git ref bb509e6fc
		bb509e6fcbae (2020-10-16; "kernel_lockdown.7: New page documenting the Kernel Lockdown feature")

and here:
<https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/git#n46>

    alias.ref, alias.ref2
	To produce git commit references, the following git aliases are
	useful.

		$ git config --global alias.ref \
			"show -s --format=tformat:'%C(auto)%h (%cs%x3B \"%s\")%C(reset)'"
		$ git config --global alias.ref2 \
			"show -s --format=tformat:'%C(auto)%h (%as, %cs%x3B \"%s\")%C(reset)'"

    core.abbrev
	Use 12 characters in abbreviated hashes.

		$ git config --global core.abbrev 12

The Fixes tag I used in this particular patch was

Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")


Have a lovely night!
Alex

> 
> > 
> > /jeff
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v1] wifi: ath9k: Fix typo

[Jeff Johnson]

On 2/24/2026 3:23 PM, Alejandro Colomar wrote:
> Hi Jeff, Greg,
> 
> On 2026-02-24T15:09:05-0800, Jeff Johnson wrote:
>>>> I don't know where I keep the patch, so I'd have to apply it from the
>>>> email to resend.  Could you amend it yourself?
>>>
>>> sure, I'll amend the patch in my pending branch
> 
> Thanks!
> 
>> I've also updated the Fixes tag to meet the expected format...
>> Fixes: c4dc0d040e35 ("ath9k: Fetch appropriate operating channel context")
> 
> Greg, I CCed you in the man-pages thread where I discussed adding the
> commit date to the Fixes tags.  I was interested in your opinion, and
> also think this could be useful in the kernel.
> 
> <https://lore.kernel.org/linux-man/3a656e90329f26d743d0904f56ae847951c852c7.1770150003.git.alx@kernel.org/>
> 
> Do you have any opinion about this?  Should I send a mail to some kernel
> mailing list to propose its use in the kernel?
> 
> The format I used is documented in the Linux man-pages here:
> <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/patches/trailer#n16>
> 
>     Fixes
> 	Add 'Fixes:' tags as necessary.  'Fixes:' trailer fields should
> 	have the following format.
> 
> 		Fixes: 12-char-hash ([author-date,] commit-date; "subject")
> 
> 	where the author date is optional, and only included if it's
> 	somehow important.  The commit date is often more important, as
> 	it's sorted, and thus can be used to find (with a binary search)
> 	a commit whose hash and subject may have collisions.  For
> 	example:
> 
> 		Fixes: bb509e6fcbae (2020-10-16; "kernel_lockdown.7: New page documenting the Kernel Lockdown feature")
> 
> 	See <CONTRIBUTING.d/git> for how to configure the alias.ref and
> 	alias.ref2 git aliases.  The commit references can be produced
> 	with them.
> 
> 		$ git ref bb509e6fc
> 		bb509e6fcbae (2020-10-16; "kernel_lockdown.7: New page documenting the Kernel Lockdown feature")
> 
> and here:
> <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/git#n46>
> 
>     alias.ref, alias.ref2
> 	To produce git commit references, the following git aliases are
> 	useful.
> 
> 		$ git config --global alias.ref \
> 			"show -s --format=tformat:'%C(auto)%h (%cs%x3B \"%s\")%C(reset)'"
> 		$ git config --global alias.ref2 \
> 			"show -s --format=tformat:'%C(auto)%h (%as, %cs%x3B \"%s\")%C(reset)'"
> 
>     core.abbrev
> 	Use 12 characters in abbreviated hashes.
> 
> 		$ git config --global core.abbrev 12
> 
> The Fixes tag I used in this particular patch was
> 
> Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")

This format doesn't conform to the format described in:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

And it fails scripts/checkpatch.pl

Review the comments from when a similar change was proposed (including a
response from Greg):
https://lore.kernel.org/all/tencent_F8CFC8ED723F6E8103B4AF3D98D63D7F1F08@qq.com/

And referencing a project which you authored as an example of how to do things
doesn't give much credibility. Please follow Linux kernel style.

/jeff

Re: [PATCH v1] wifi: ath9k: Fix typo

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

Hi Jeff,

On 2026-02-24T16:04:51-0800, Jeff Johnson wrote:
> This format doesn't conform to the format described in:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> 
> And it fails scripts/checkpatch.pl
> 
> Review the comments from when a similar change was proposed (including a
> response from Greg):
> https://lore.kernel.org/all/tencent_F8CFC8ED723F6E8103B4AF3D98D63D7F1F08@qq.com/

Thanks!  I'll reply there.

> 
> And referencing a project which you authored as an example of how to do things
> doesn't give much credibility. Please follow Linux kernel style.

Sure; for this patch please use the amended one.  I was pointing to that
for discussing changing the format used in the kernel, globally, not to
use it in this patch.


Have a lovely night!
Alex

> 
> /jeff

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v1] wifi: ath9k: Fix typo

[Greg KH]

On Tue, Feb 24, 2026 at 10:27:56PM +0100, Alejandro Colomar wrote:
> Hi Jeff,
> 
> On 2026-02-24T10:45:02-0800, Jeff Johnson wrote:
> > On 2/23/2026 7:17 AM, Toke Høiland-Jørgensen wrote:
> > > Alejandro Colomar <alx@kernel.org> writes:
> > > 
> > >> This only worked by chance, because all callers of this macro used the
> > >> same identifiers that were expected by the macro.
> > >>
> > >> 	$ grep -rn ath_for_each_chanctx
> > >> 	drivers/net/wireless/ath/ath9k/main.c:1576:	ath_for_each_chanctx(sc, ctx)
> > >> 	drivers/net/wireless/ath/ath9k/main.c:2554:	ath_for_each_chanctx(sc, ctx) {
> > >> 	drivers/net/wireless/ath/ath9k/channel.c:165:	ath_for_each_chanctx(sc, ctx) {
> > >> 	drivers/net/wireless/ath/ath9k/channel.c:291:	ath_for_each_chanctx(sc, ctx) {
> > >> 	drivers/net/wireless/ath/ath9k/channel.c:861:	ath_for_each_chanctx(sc, ctx) {
> > >> 	drivers/net/wireless/ath/ath9k/debug.c:717:	ath_for_each_chanctx(sc, ctx) {
> > >> 	drivers/net/wireless/ath/ath9k/ath9k.h:446:#define ath_for_each_chanctx(_sc, _ctx)                               \
> > >>
> > >> Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")
> > 
> > I'm dropping the Fixes tag since the existing code actually works and hence
> > there is no need to backport to LTS kernels.
> 
> Sounds reasonable.  Alternatively, a line next to it saying
> 
> 	[Do not backport]
> 
> would work, I guess.
> 
> Greg, I've seen this situation already a few times.  A Fixes tag getting
> removed to avoid triggering a stable backport.  But I think keeping the
> Fixes tag could be useful.  Should we have a standard way to document
> that a patch fixes an old commit without meaning that it should be
> backported?  Maybe something like this?:
> 
> 	[Do not backport to stable]
> 	Fixes: ...

As per the in-kernel documentation file
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

	There furthermore is a variant of the stable tag you can use to make the stable
	team's backporting tools (e.g AUTOSEL or scripts that look for commits
	containing a 'Fixes:' tag) ignore a change::

	     Cc: <stable+noautosel@kernel.org> # reason goes here, and must be present

So I think it is documented already :)

thanks,

greg k-h

Re: [PATCH v1] wifi: ath9k: Fix typo

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

Hi Greg,

On 2026-02-24T13:37:09-0800, Greg KH wrote:
> > 	[Do not backport to stable]
> > 	Fixes: ...
> 
> As per the in-kernel documentation file
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> 
> 	There furthermore is a variant of the stable tag you can use to make the stable
> 	team's backporting tools (e.g AUTOSEL or scripts that look for commits
> 	containing a 'Fixes:' tag) ignore a change::
> 
> 	     Cc: <stable+noautosel@kernel.org> # reason goes here, and must be present
> 
> So I think it is documented already :)

Thanks!  I'll use that.  :)


Cheers,
Alex

> 
> thanks,
> 
> greg k-h

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v1] wifi: ath9k: Fix typo

[Jeff Johnson]

On Sun, 21 Dec 2025 23:25:54 +0100, Alejandro Colomar wrote:
> This only worked by chance, because all callers of this macro used the
> same identifiers that were expected by the macro.
> 
> 	$ grep -rn ath_for_each_chanctx
> 	drivers/net/wireless/ath/ath9k/main.c:1576:	ath_for_each_chanctx(sc, ctx)
> 	drivers/net/wireless/ath/ath9k/main.c:2554:	ath_for_each_chanctx(sc, ctx) {
> 	drivers/net/wireless/ath/ath9k/channel.c:165:	ath_for_each_chanctx(sc, ctx) {
> 	drivers/net/wireless/ath/ath9k/channel.c:291:	ath_for_each_chanctx(sc, ctx) {
> 	drivers/net/wireless/ath/ath9k/channel.c:861:	ath_for_each_chanctx(sc, ctx) {
> 	drivers/net/wireless/ath/ath9k/debug.c:717:	ath_for_each_chanctx(sc, ctx) {
> 	drivers/net/wireless/ath/ath9k/ath9k.h:446:#define ath_for_each_chanctx(_sc, _ctx)                               \
> 
> [...]

Applied, thanks!

[1/1] wifi: ath9k: Fix typo
      commit: a8911fbeff8bee4fe3376c5044b64fbf3cceb78e

Best regards,
-- 
Jeff Johnson <jeff.johnson@oss.qualcomm.com>