Hi Jeff, Greg,
On 2026-02-24T15:09:05-0800, Jeff Johnson wrote:
> >> I don't know where I keep the patch, so I'd have to apply it from the
> >> email to resend. Could you amend it yourself?
> >
> > sure, I'll amend the patch in my pending branch
Thanks!
> I've also updated the Fixes tag to meet the expected format...
> Fixes: c4dc0d040e35 ("ath9k: Fetch appropriate operating channel context")
Greg, I CCed you in the man-pages thread where I discussed adding the
commit date to the Fixes tags. I was interested in your opinion, and
also think this could be useful in the kernel.
Do you have any opinion about this? Should I send a mail to some kernel
mailing list to propose its use in the kernel?
The format I used is documented in the Linux man-pages here:
Fixes
Add 'Fixes:' tags as necessary. 'Fixes:' trailer fields should
have the following format.
Fixes: 12-char-hash ([author-date,] commit-date; "subject")
where the author date is optional, and only included if it's
somehow important. The commit date is often more important, as
it's sorted, and thus can be used to find (with a binary search)
a commit whose hash and subject may have collisions. For
example:
Fixes: bb509e6fcbae (2020-10-16; "kernel_lockdown.7: New page documenting the Kernel Lockdown feature")
See for how to configure the alias.ref and
alias.ref2 git aliases. The commit references can be produced
with them.
$ git ref bb509e6fc
bb509e6fcbae (2020-10-16; "kernel_lockdown.7: New page documenting the Kernel Lockdown feature")
and here:
alias.ref, alias.ref2
To produce git commit references, the following git aliases are
useful.
$ git config --global alias.ref \
"show -s --format=tformat:'%C(auto)%h (%cs%x3B \"%s\")%C(reset)'"
$ git config --global alias.ref2 \
"show -s --format=tformat:'%C(auto)%h (%as, %cs%x3B \"%s\")%C(reset)'"
core.abbrev
Use 12 characters in abbreviated hashes.
$ git config --global core.abbrev 12
The Fixes tag I used in this particular patch was
Fixes: c4dc0d040e35 (2014-06-19; "ath9k: Fetch appropriate operating channel context")
Have a lovely night!
Alex
>
> >
> > /jeff
>
--