Re: [PATCH wireless-next v3] wifi: mac80211: Fix AAD/Nonce computation for management frames with MLO

[Jouni Malinen <j@w1.fi>]

On Thu, Feb 12, 2026 at 09:56:01AM +0530, Sai Pratyusha Magam wrote:
> diff --git a/drivers/net/wireless/virtual/mac80211_hwsim.c b/drivers/net/wireless/virtual/mac80211_hwsim.c
> @@ -4189,6 +4225,7 @@ static int mac80211_hwsim_change_nan_config(struct ieee80211_hw *hw,
>  	.start_nan = mac80211_hwsim_start_nan,                  \
>  	.stop_nan = mac80211_hwsim_stop_nan,                    \
>  	.nan_change_conf = mac80211_hwsim_change_nan_config,    \
> +	.set_key = mac80211_hwsim_set_key,                     \
>  	HWSIM_DEBUGFS_OPS

Defining the set_key callback makes mac80211 disable various features
and not all of them were covered below:

> @@ -5621,6 +5658,7 @@ static int mac80211_hwsim_new_radio(struct genl_info *info,
> +	hw->wiphy->flags |= WIPHY_FLAG_IBSS_RSN;

That's one of features that get disabled by default in mac80211 if a
driver defines ops->set_key. In addition to that, these ext_features
need to be enabled in mac80211_hwsim:

wiphy_ext_feature_set(wiphy,
		      NL80211_EXT_FEATURE_SPP_AMSDU_SUPPORT);
wiphy_ext_feature_set(local->hw.wiphy,
		      NL80211_EXT_FEATURE_CAN_REPLACE_PTK0);
wiphy_ext_feature_set(local->hw.wiphy,
		      NL80211_EXT_FEATURE_EXT_KEY_ID);
 
-- 
Jouni Malinen                                            PGP id EFC895FA