From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A807337F007 for ; Sun, 8 Mar 2026 13:28:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772976483; cv=none; b=KDGEEQFQg9fTr2M40w7ZJ4cim6Ggg8eDpjbVuztoex8vVXlWmRW/VSdfCqIH73HYA5G+I5VCfatomIIAQv103pLGEkXWdY1SDv6hxHLRC2JZOWuGgGSal9mMoUfTdHWrBnhlFQZU0DTrSaq71Dg9Oq/CNfGGsBXroCyzFq0JlX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772976483; c=relaxed/simple; bh=kqMXEL+AjqzO9zZs1WrwVKYrFSMYBdQt7xK0a+R1F1U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KvcHYOOn8A+P3pSdNUZ0P1fiCZNIU4bIqgEGpk8u1fiO/1nKj5qgcdHXAyoCh8lD8RWFi6MnJ/E74r0nUdU4UMCveZPHNiKmexX0GEQNeAs4sUJqrl4bfwpR+rxgUw4NRHvIcXb8mrCaDAmc8FnueRe3P/pCu1MzP5SzFghR4cI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lQVTWvEb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lQVTWvEb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04966C116C6; Sun, 8 Mar 2026 13:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772976483; bh=kqMXEL+AjqzO9zZs1WrwVKYrFSMYBdQt7xK0a+R1F1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lQVTWvEbIbWxVRB+nnQ4THO0nQMH4jhflZI83tL3wT2M8YHSX5Nq1/KPksoVgObh/ 064FzmJULl8UHxxgLWols5i0WKsbeQi/PduJT+ZcUTHlja3H0Tsfy5JgQ68akhdMIc ey53LGKO0GNmXrarF6SzgGg6/o9VVuj6Jije1ytlqy6xBa95bhyWn6bFvvZnoTmyCU T5t95B2KvaXYmL6+sMBU5x7cMI9iYAcPhPCnR6Y/BDuQBORf3wnF7BJms6uYES5Bea B3ZRk7nrtMy4OnupjjQG7gbULjQlYdd9HnOjs6+nCUfT/0n/at7pJj1Kl2OH3HT57I JAsdWrmPx5+Kg== Date: Sun, 8 Mar 2026 14:28:00 +0100 From: Lorenzo Bianconi To: Lachlan Hodges Cc: Johannes Berg , linux-wireless@vger.kernel.org Subject: Re: [PATCH wireless-next] wifi: mac80211: Remove deleted sta links in ieee80211_ml_reconf_work() Message-ID: References: <20260307-mac80211-reconf-remove-sta-link-v1-1-efe58070cd36@kernel.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jnS7Ya0bgm6rJ7T1" Content-Disposition: inline In-Reply-To: --jnS7Ya0bgm6rJ7T1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > + rcu_read_lock(); > > + sta =3D sta_info_get(sdata, sdata->vif.cfg.ap_addr); > > + if (sta) { > > + unsigned long removed_links =3D sdata->u.mgd.removed_links; > > + unsigned int link_id; > > + > > + for_each_set_bit(link_id, &removed_links, > > + IEEE80211_MLD_MAX_NUM_LINKS) > > + ieee80211_sta_free_link(sta, link_id); > > + } > > + rcu_read_unlock(); > > + >=20 > Could use scoped_guard(rcu) instead? I do not have a strong opinion here. @Johannes: Which one do you prefer? Regards, Lorenzo >=20 > lachlan --jnS7Ya0bgm6rJ7T1 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCaa15YAAKCRA6cBh0uS2t rJiqAP9RpKiuRbRIYHeTrzE4E92FaZAr6yhgB9orb1VbH+e2igEA87jLRXdNSJ5h 9QWH36csDBB7GlOASJXxnwTQ+ffYJw0= =6hrI -----END PGP SIGNATURE----- --jnS7Ya0bgm6rJ7T1--