From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC3BB27F01E;
	Mon,  9 Mar 2026 05:04:08 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1773032648; cv=none; b=jG0aE14htOs9xLsHx2QuzMpbaS7mS3XzDCbfaLPS2NFY2A/Bm/MXgP+dR1wF4NL12WBrT1QO+PLiiJ1WtihlEr8zoPmVk05HvSbwL7ZidsIsebh4JdfpcT1OWuD1uTfg66FxXwFqPf4TgRdYev/prupbWMUo2ysWz1CpL9uoMRE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1773032648; c=relaxed/simple;
	bh=nlljNcMEmbBFbwMlFYIHGVsIVpYN3RV0Ax1svPiwBxc=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=p9eZ2ogjxN8JhiD+O5n9+BBz1NEY+/luz1NFXYG2quHY7ZSiehuFz2EzRKUYALqMc5DqFG5VI56qU5L961ScXsa0Xp/9u0tBKiAyZ3yUKPyw3OspfFw27NIec+BPilxaKWtX8kG3vQXGQEDPKUQ0nneMTBjjKRrKzn8eKV9AK48=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kifEbwgH; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kifEbwgH"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91F1CC4CEF7;
	Mon,  9 Mar 2026 05:03:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1773032648;
	bh=nlljNcMEmbBFbwMlFYIHGVsIVpYN3RV0Ax1svPiwBxc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=kifEbwgH38BQFm5WxRPTeN3CNvd4K+gkDSR75UnwaDfst+kFhLsxDZG1gwvv0J2zV
	 niepDzatZrDdxCyHDXvhhEYaaQDTaD9gHpvogArXx689+0dN/J0l163W+YpD1I7TTg
	 KoowqFeMkUjngRi6nIIGr6ofrkDkLXrijpMGjI44dDeljAI41dks9IHL49Qcbc2Jtx
	 EsgvJI3bOn0gaQgOvxo+NlrKVhm8I++VaArWtdCGv7V3J5RxvyJ0DpEE0gVbE3av+F
	 YXcofqmqvy7VrQqhyw3fGViE5VGK9u0SxRxFRyCohcNvIvvlghkKvcJ8/a4adVDxJr
	 2HH0J6B12cKPg==
Date: Mon, 9 Mar 2026 10:33:49 +0530
From: Sumit Garg <sumit.garg@kernel.org>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	linux-media@vger.kernel.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
	linux-remoteproc@vger.kernel.org, andersson@kernel.org,
	konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run,
	akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev,
	jesszhan0024@gmail.com, marijn.suijten@somainline.org,
	airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com,
	dikshita.agarwal@oss.qualcomm.com, bod@kernel.org,
	mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org,
	trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com,
	pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com,
	tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com,
	srinivas.kandagatla@oss.qualcomm.com,
	amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org,
	op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com,
	skare@qti.qualcomm.com, Sumit Garg <sumit.garg@oss.qualcomm.com>
Subject: Re: [PATCH 02/14] firmware: qcom: Add a generic PAS service
Message-ID: <aa5UtcfiIe78oj1S@sumit-xelite>
References: <20260306105027.290375-1-sumit.garg@kernel.org>
 <20260306105027.290375-3-sumit.garg@kernel.org>
 <00a7e65d-aad3-4029-af51-ff0870e65595@oss.qualcomm.com>
Precedence: bulk
X-Mailing-List: linux-wireless@vger.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <00a7e65d-aad3-4029-af51-ff0870e65595@oss.qualcomm.com>

On Fri, Mar 06, 2026 at 07:49:07AM -0800, Jeff Johnson wrote:
> On 3/6/2026 2:50 AM, Sumit Garg wrote:
> 
> I missed one k-doc warning...
> 
> > +/**
> > + * qcom_scm_pas_auth_and_reset() - Authenticate the given peripheral firmware
> 
> s/scm_//
> 
> Warning: drivers/firmware/qcom/qcom_pas.c:173 expecting prototype for
> qcom_scm_pas_auth_and_reset(). Prototype was for qcom_pas_auth_and_reset() instead
> 

Thanks for the k-doc warnings report, I will fix them in the next
version.

-Sumit

> > + *				   and reset the remote processor
> > + * @pas_id:	peripheral authentication service id
> > + *
> > + * Return 0 on success.
> > + */
> > +int qcom_pas_auth_and_reset(u32 pas_id)
> > +{
> > +	if (ops_ptr)
> > +		return ops_ptr->auth_and_reset(ops_ptr->dev, pas_id);
> > +
> > +	return -ENODEV;
> > +}
>