From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C24903B7741 for ; Thu, 12 Mar 2026 10:39:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773311996; cv=none; b=AkXyI+L3l9J9S6EhSsYNZu3Ukx55Kv2ZtSo9ocKOToxM6oNXpKob0a6wkUR/E6QwlKv4NEYltF5BDRnrWQ/oL2zzgcL9Tn1xxaNXJs+9mO93ne1LEOzR98bVopTYlKXTmSjixk7U+qiPO7VPHra1mO4r8gJ65CxpM+/zl/horLs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773311996; c=relaxed/simple; bh=pDVbEPackjHOkDSkszUjMWANS+pLeXpAW11n0EUfPZ8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LssQlTwtJPaX26CastetSOzrbF3HMI6if4R0POpNExNIm8qzgnmvJj0mkLbZePsUgvJDueiE6GcmrYcZgjXmS64j6GodhYCtrT0OYG3T3X0hKbLBLUaq/sk5nk/g8e8RTMZNfsY08X/kDyILf7lo0A3X3jR/jy2MEN6ISJyOJDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EmjorNFE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EmjorNFE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D59C5C4CEF7; Thu, 12 Mar 2026 10:39:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773311996; bh=pDVbEPackjHOkDSkszUjMWANS+pLeXpAW11n0EUfPZ8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EmjorNFECXNJEhIvMFPJMesvdQV53BZgUT9zKAHZH7ebZHaOxKcNRswBeoUjH2k73 E631tm6hRN3pWxf5kKU4+AqhISKwMz24d93WPDRAHeM18j8pZlIlkXQc4GecTpe5xR gqipAG4U7ITlClII9Er+976ctAYk/A2PoK9ID6uVybupVDeRgRXDbH0xRNJAYyIXiA XL2iHnrzvK3KCC4in6oL3QxN3FRv6FJdMdvTwrDDj5X+3t0AbHGJJor4bSP2z/Dzim 6GfEIY+RZCxDEGAspRxpnTzfKyAPtK/jajLG29R0DzPiwGguaZW8P+RSKIRpMnh7d4 SN3xXVg5Ny23g== Date: Thu, 12 Mar 2026 11:39:53 +0100 From: Lorenzo Bianconi To: Shayne Chen Cc: Felix Fietkau , linux-wireless , Ryder Lee , Evelyn Tsai , Money Wang , linux-mediatek , Peter Chiu Subject: Re: [PATCH mt76 1/6] wifi: mt76: mt7996: fix RRO EMU configuration Message-ID: References: <20260312095724.2117448-1-shayne.chen@mediatek.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iguTs+hpi+rd15oI" Content-Disposition: inline In-Reply-To: <20260312095724.2117448-1-shayne.chen@mediatek.com> --iguTs+hpi+rd15oI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > From: Peter Chiu >=20 > Use the correct helper to update specific bitfields instead of > overwriting the entire register. >=20 > Fixes: eedb427eb260 ("wifi: mt76: mt7996: Enable HW RRO for MT7992 chipse= t") > Signed-off-by: Peter Chiu > Signed-off-by: Shayne Chen Acked-by: Lorenzo Bianconi > --- > drivers/net/wireless/mediatek/mt76/mt7996/init.c | 3 +-- > drivers/net/wireless/mediatek/mt76/mt7996/mac.c | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/init.c b/drivers/n= et/wireless/mediatek/mt76/mt7996/init.c > index 5aaa93767109..f3239f530aea 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7996/init.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7996/init.c > @@ -873,8 +873,7 @@ void mt7996_rro_hw_init(struct mt7996_dev *dev) > } > } else { > /* set emul 3.0 function */ > - mt76_wr(dev, MT_RRO_3_0_EMU_CONF, > - MT_RRO_3_0_EMU_CONF_EN_MASK); > + mt76_set(dev, MT_RRO_3_0_EMU_CONF, MT_RRO_3_0_EMU_CONF_EN_MASK); > =20 > mt76_wr(dev, MT_RRO_ADDR_ARRAY_BASE0, > dev->wed_rro.addr_elem[0].phy_addr); > diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c b/drivers/ne= t/wireless/mediatek/mt76/mt7996/mac.c > index a415cc610eee..86aaf0f29e28 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c > @@ -2559,7 +2559,7 @@ void mt7996_mac_reset_work(struct work_struct *work) > mt7996_dma_start(dev, false, false); > =20 > if (!is_mt7996(&dev->mt76) && dev->mt76.hwrro_mode =3D=3D MT76_HWRRO_V3) > - mt76_wr(dev, MT_RRO_3_0_EMU_CONF, MT_RRO_3_0_EMU_CONF_EN_MASK); > + mt76_set(dev, MT_RRO_3_0_EMU_CONF, MT_RRO_3_0_EMU_CONF_EN_MASK); > =20 > if (mtk_wed_device_active(&dev->mt76.mmio.wed)) { > u32 wed_irq_mask =3D MT_INT_TX_DONE_BAND2 | > --=20 > 2.51.0 >=20 --iguTs+hpi+rd15oI Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCabKX+QAKCRA6cBh0uS2t rIx5AP0dKoujlT6i8aItT2p8vcGNJ/KD6Gf6Zvu4+zxi7rYu5wEAghyiR8aWNO46 mhR6BaScV2AVgazIBnR5cgjD2XmMWAQ= =SIDW -----END PGP SIGNATURE----- --iguTs+hpi+rd15oI--