public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linusw@kernel.org>
Cc: "Kalle Valo" <kvalo@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>,
	"Alban Bedel" <albeu@free.fr>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Michał Kępień" <kernel@kempniu.pl>,
	linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3] wifi: ath9k: Obtain system GPIOS from descriptors
Date: Fri, 13 Mar 2026 10:19:23 +0200	[thread overview]
Message-ID: <abPIi0qsJDDSdfLp@ashevche-desk.local> (raw)
In-Reply-To: <CAD++jLmerNFyjGXAH9n9MKNAkcTSy3swg53=PARMqsXKjT7R3w@mail.gmail.com>

On Thu, Mar 12, 2026 at 10:26:06PM +0100, Linus Walleij wrote:
> Hi Andy,
> 
> (I'll obviously fix all the syntax issues for v4)
> 
> On Thu, Mar 12, 2026 at 5:24 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > Have you considered using software nodes instead?
> 
> That's the big question. And also: have I considered adding device
> tree bindings to map to those look-ups, that would provide a way for
> new users of these devices to actually do the right thing. I thought of both!
> 
> The big problem is that we don't have a handle on the device
> and it's name, because it comes from the device tree and
> could be named anything. Same thing with the GPIO controller.
> 
> If we register lookups or software nodes in the GPIO driver we
> don't have a reference to the ath9k device or its name, and if we
> register it in the ath9k device, we don't have a handle on the
> GPIO controller or its name.
> 
> All of these GPIOs "should have" had bindings and "should have"
> been in the device tree, but they are not, and I think some of those
> device trees are even outside of the Linux kernel so we can't really
> fix them either :( it's a mess, I'm just stirring the mud to try and
> make it a bit better by removing the global GPIO numbers.

Thanks for this elaboration! Since Bart is the person who wants to move
the lookup tables to software nodes, I leave that part to him. For time
being your patch looks good (after addressing style and minor issues I
pointed out), feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
to the next version.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-03-13  8:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 15:09 [PATCH v3] wifi: ath9k: Obtain system GPIOS from descriptors Linus Walleij
2026-03-12 16:23 ` Andy Shevchenko
2026-03-12 21:26   ` Linus Walleij
2026-03-13  8:19     ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abPIi0qsJDDSdfLp@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=albeu@free.fr \
    --cc=arnd@arndb.de \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brgl@bgdev.pl \
    --cc=kernel@kempniu.pl \
    --cc=kvalo@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox