From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5496C2DE702; Mon, 16 Mar 2026 02:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773626546; cv=none; b=bda71OqaRw/56iijCXvOSdf8TBl4gpGB7SiAOHBZUBXphXMpQyrmBxcVbOSVx9DA4nNnjmXSMKsfjMKfHGRvFp1mOvYFvAfnPQwpcDARbZLa1d++DY922tbtGCDPU9IeXZvR8yFrEqtVJjanOqYpI2Oo+QvcH0SPoF/ujlBKAII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773626546; c=relaxed/simple; bh=kkXUNwiD69Xpf87E5BcMyOtlNTMPeQ7/lEHjHLgRL+A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W/JhU8K7rphWRiYlmYtHhijyCL0H46MHWJoAJJBJAWlZvb0T02gnWshqtbfiiKcxOPkK0OKzpdI1zN5f8VZ5E1XdzOpCbQfyYEVOkCCZcJov6GbIxLIJHSYqYmN56fmKrTWLSulDLGezxM9liThq8omAlerZmI9ahe1ry7RoOpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PaY9HkVE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PaY9HkVE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24C2DC2BC9E; Mon, 16 Mar 2026 02:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773626545; bh=kkXUNwiD69Xpf87E5BcMyOtlNTMPeQ7/lEHjHLgRL+A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PaY9HkVEV6krRsQgLxwkiO7yZMgrlVrPpLXeYQAR7IAx5MDR7TUwQaFz5V5qBSv+A 3YoimJldxSYQPdNcTuf1q8DiCAdq3vsH/5xg42nBbHksinhtYNfrYPZega6m4y/sYo dSVfROBNQjnwOQiwv2Iv9yfHYtnCcqA+93lxvlHWuuM58XLuXbmq+J2EL7r6iTqBTr Zn8z8tWJ2xCvEIfT8gIb/4uorPM0rZ/envKWWfSJ/4LQJZFfI5sEgx7a5FPCeNQBPE 96u6lp0SEhMsftM3FyXouu+2DSxMYqsHHr06OStUhqnzmBbQFyHf9bdRGjM036xEQk f7OGCBrm7fLPg== Date: Sun, 15 Mar 2026 21:02:19 -0500 From: Bjorn Andersson To: Daniel Lezcano Cc: Jeff Johnson , konradybcio@kernel.org, linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Subject: Re: [PATCH v1 0/8] Group QMI service IDs into the QMI header Message-ID: References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> <9cc7638f-1232-4cb7-b4d7-cdac66a2f4ba@oss.qualcomm.com> <3283cbae-4100-484c-9b00-1d7111c62456@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3283cbae-4100-484c-9b00-1d7111c62456@oss.qualcomm.com> On Tue, Mar 10, 2026 at 01:09:08AM +0100, Daniel Lezcano wrote: > On 3/10/26 00:50, Jeff Johnson wrote: > > On 3/9/2026 4:03 PM, Daniel Lezcano wrote: > > > The different subsystems implementing the QMI service protocol are > > > using their own definition of the service id. It is not a problem but > > > it results on having those duplicated with different names but the > > > same value and without consistency in their name. > > > > > > It makes more sense to unify their names and move the definitions in > > [ ... ] > > > prefix for wireless drivers is simply wifi: : > > so s/net: drivers: wireless:/wifi:/ > > Noted, thanks > > > > remoteproc: qcom: Use the unified QMI service ID instead of defining > > > it locally > > > slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of > > > defining it locally > > > soc: qcom: pdr: Use the unified QMI service ID instead of defining it > > > locally > > > ALSA: usb-audio: qcom: Use the unified QMI service ID instead of > > > defining it locally > > > samples: qmi: Use the unified QMI service ID instead of defining it > > > locally > > > > > > drivers/net/ipa/ipa_qmi.c | 6 ++---- > > > drivers/net/wireless/ath/ath10k/qmi.c | 2 +- > > > drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 - > > > drivers/net/wireless/ath/ath11k/qmi.c | 2 +- > > > drivers/net/wireless/ath/ath11k/qmi.h | 1 - > > > drivers/net/wireless/ath/ath12k/qmi.c | 2 +- > > > drivers/net/wireless/ath/ath12k/qmi.h | 1 - > > > drivers/remoteproc/qcom_sysmon.c | 2 +- > > > drivers/slimbus/qcom-ngd-ctrl.c | 5 ++--- > > > drivers/soc/qcom/pdr_interface.c | 4 ++-- > > > drivers/soc/qcom/pdr_internal.h | 3 --- > > > drivers/soc/qcom/qcom_pd_mapper.c | 2 +- > > > include/linux/soc/qcom/qmi.h | 12 ++++++++++++ > > > samples/qmi/qmi_sample_client.c | 2 +- > > > sound/usb/qcom/qc_audio_offload.c | 2 +- > > > sound/usb/qcom/usb_audio_qmi_v01.h | 1 - > > > > You are touching a lot of subsystems with a single series. > > How do you plan on having these land? > > Do you have a maintainer who will take all of these through their tree? > > Yes I thought Bjorn or Konrad would take them with the acked-by from the > different subsystems As we haven't received any such acks, I pulled patch 1 into an immutable branch and pushed it here: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git 20260309230346.3584252-2-daniel.lezcano@oss.qualcomm.com Other maintainers can use this to pull respective changes, or you can repost the individual patches with this (or follow up once it's in -rc1). Regards, Bjorn