From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD76CB663 for ; Fri, 20 Sep 2024 06:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726813652; cv=none; b=KAjcbEhH4aBA7TimXTR9n0zbCcWb0dfutVs5M15tG7I/CDmh10PjtOKNaRJsXm9xyjPQqfctUtaU9BGAnLJ96gmnvmV7FAO7dYLHgq7LF7rx2j67OaK3cOQbrJ1K5mMW0bpj0IF5hjvGG4aXzicQr0oR1orzYEEiGMuHE9b0Cb8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726813652; c=relaxed/simple; bh=2oCWAS0vsgQQ01bQYmSMGGxDngcvV8w1Bf+FkGQuRzo=; h=From:To:CC:Subject:Date:Message-ID:References:Content-Type: MIME-Version; b=D5VuVvMwvZgGClVXb1di0V0qJUuCtmpLZwLE415YP3+n3I5sezd8HrKNI9JMy4iRr1ra0awGAciSx8aEfacraABcqdZrkGgtBanifK1CqDKSDCxPJsvEAh+tVtbaunV+QfO1nJuefm+qRaAY8EDvSKhT/VTUKdkbE1YoaQmJOWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; dkim=temperror (0-bit key) header.d=realtek.com header.i=@realtek.com header.b=Nj7I2y5f; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=realtek.com header.i=@realtek.com header.b="Nj7I2y5f" X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 48K6REC30669408, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=realtek.com; s=dkim; t=1726813634; bh=2oCWAS0vsgQQ01bQYmSMGGxDngcvV8w1Bf+FkGQuRzo=; h=From:To:CC:Subject:Date:Message-ID:References:Content-Type: Content-Transfer-Encoding:MIME-Version; b=Nj7I2y5fk2nrTBJRca4F9m2jcOv0bCjOSBpONPZHS3afqNA3bQ4moOdMVVASZg2oa +fVuR+FsiUVeHIYCTHCPfhaSjKTBa2OraHN3IvzNwxG/2CC2G4HjHcWylJqIG/Q6e3 Ph7WIh/RlbGiMo4ONAKH6IPAI2xfM9lWVE7NFHtBHmLz5d1Gu4Oz+U0A2N6Xgune5i ABOkK0ZSvlGsZYl24/lHzVnjQXNzmieudiCwN5X0L6M8PT36jBxn5xeqFSZ5z23hny Rl4xjqA6GVe82azyKiEuc9t1K5NTr0K48FEXyLk4nVV3x61A++Rkaa8wJOfT9t+hQ7 e0617kZC4KNRA== Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/3.05/5.92) with ESMTPS id 48K6REC30669408 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Sep 2024 14:27:14 +0800 Received: from RTEXMBS05.realtek.com.tw (172.21.6.98) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 20 Sep 2024 14:27:14 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS05.realtek.com.tw (172.21.6.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 20 Sep 2024 14:27:14 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::2882:4142:db9:db1f]) by RTEXMBS04.realtek.com.tw ([fe80::2882:4142:db9:db1f%11]) with mapi id 15.01.2507.035; Fri, 20 Sep 2024 14:27:14 +0800 From: Ping-Ke Shih To: "pbrobinson@gmail.com" CC: "johannes@sipsolutions.net" , "linux-wireless@vger.kernel.org" Subject: RE: [PATCH v2 2/2] wifi: rtw88: use ieee80211_purge_tx_queue() to purge TX skb Thread-Topic: [PATCH v2 2/2] wifi: rtw88: use ieee80211_purge_tx_queue() to purge TX skb Thread-Index: AQHa9DSxPPAHrjHHCkiWzpTbPs2zeLIygfOAgC3gdzA= Date: Fri, 20 Sep 2024 06:27:14 +0000 Message-ID: References: <20240822014255.10211-1-pkshih@realtek.com> <20240822014255.10211-2-pkshih@realtek.com> Accept-Language: en-US, zh-TW Content-Language: zh-TW Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Ping-Ke Shih wrote: >=20 > Hi Peter, >=20 > Could you please test v2 again? Thanks. Still no reply from peter though.=20 >=20 > Ping-Ke Shih wrote: > > When removing kernel modules by: > > rmmod rtw88_8723cs rtw88_8703b rtw88_8723x rtw88_sdio rtw88_core > > > > Driver uses skb_queue_purge() to purge TX skb, but not report tx status > > causing "Have pending ack frames!" warning. Use ieee80211_purge_tx_queu= e() > > to correct this. > > > > Since ieee80211_purge_tx_queue() doesn't take locks, to prevent racing > > between TX work and purge TX queue, flush and destroy TX work in advanc= e. > > > > wlan0: deauthenticating from aa:f5:fd:60:4c:a8 by local > > choice (Reason: 3=3DDEAUTH_LEAVING) > > ------------[ cut here ]------------ > > Have pending ack frames! > > WARNING: CPU: 3 PID: 9232 at net/mac80211/main.c:1691 > > ieee80211_free_ack_frame+0x5c/0x90 [mac80211] > > CPU: 3 PID: 9232 Comm: rmmod Tainted: G C > > 6.10.1-200.fc40.aarch64 #1 > > Hardware name: pine64 Pine64 PinePhone Braveheart > > (1.1)/Pine64 PinePhone Braveheart (1.1), BIOS 2024.01 01/01/2024 > > pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=3D--) > > pc : ieee80211_free_ack_frame+0x5c/0x90 [mac80211] > > lr : ieee80211_free_ack_frame+0x5c/0x90 [mac80211] > > sp : ffff80008c1b37b0 > > x29: ffff80008c1b37b0 x28: ffff000003be8000 x27: 0000000000000000 > > x26: 0000000000000000 x25: ffff000003dc14b8 x24: ffff80008c1b37d0 > > x23: ffff000000ff9f80 x22: 0000000000000000 x21: 000000007fffffff > > x20: ffff80007c7e93d8 x19: ffff00006e66f400 x18: 0000000000000000 > > x17: ffff7ffffd2b3000 x16: ffff800083fc0000 x15: 0000000000000000 > > x14: 0000000000000000 x13: 2173656d61726620 x12: 6b636120676e6964 > > x11: 0000000000000000 x10: 000000000000005d x9 : ffff8000802af2b0 > > x8 : ffff80008c1b3430 x7 : 0000000000000001 x6 : 0000000000000001 > > x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000 > > x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff000003be8000 > > Call trace: > > ieee80211_free_ack_frame+0x5c/0x90 [mac80211] > > idr_for_each+0x74/0x110 > > ieee80211_free_hw+0x44/0xe8 [mac80211] > > rtw_sdio_remove+0x9c/0xc0 [rtw88_sdio] > > sdio_bus_remove+0x44/0x180 > > device_remove+0x54/0x90 > > device_release_driver_internal+0x1d4/0x238 > > driver_detach+0x54/0xc0 > > bus_remove_driver+0x78/0x108 > > driver_unregister+0x38/0x78 > > sdio_unregister_driver+0x2c/0x40 > > rtw_8723cs_driver_exit+0x18/0x1000 [rtw88_8723cs] > > __do_sys_delete_module.isra.0+0x190/0x338 > > __arm64_sys_delete_module+0x1c/0x30 > > invoke_syscall+0x74/0x100 > > el0_svc_common.constprop.0+0x48/0xf0 > > do_el0_svc+0x24/0x38 > > el0_svc+0x3c/0x158 > > el0t_64_sync_handler+0x120/0x138 > > el0t_64_sync+0x194/0x198 > > ---[ end trace 0000000000000000 ]--- > > > > Reported-by: Peter Robinson > > Closes: > > > https://lore.kernel.org/linux-wireless/CALeDE9OAa56KMzgknaCD3quOgYuEHFx9_= hcT=3DOFgmMAb+8MPyA@mail.gmail. > > com/ > > Signed-off-by: Ping-Ke Shih I added some test code to be easier to reproduce this problem on USB device= =20 named 8723DU, and this patch can fix the problem, so=20 Tested-by: Ping-Ke Shih # 8723DU