public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Zong-Zhe Yang <kevin_yang@realtek.com>
To: Markus Elfring <Markus.Elfring@web.de>,
	Zilin Guan <zilin@seu.edu.cn>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Ping-Ke Shih" <pkshih@realtek.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	Jianhao Xu <jianhao.xu@seu.edu.cn>
Subject: RE: [PATCH] wifi: rtw89: debug: Fix memory leak in __print_txpwr_map()
Date: Fri, 16 Jan 2026 11:41:31 +0000	[thread overview]
Message-ID: <acc90353107248b98215847e56bb374b@realtek.com> (raw)
In-Reply-To: <1d32418f-c315-4ce4-9b4c-6781bda72cfe@web.de>

Markus Elfring <Markus.Elfring@web.de> wrote:
> 
> …
> > Fix this by freeing the temporary buffer bufp in the error path.
> …
> 
> How do you think about to use an attribute like “__free(vfree)”?
> https://elixir.bootlin.com/linux/v6.19-rc5/source/drivers/net/wireless/realtek/rtw89/debug.c#
> L815-L858
> 

Using __free(XXX) is fine to me.
But, I don't seem to see DEFINE_FREE(vfree, ...) yet.
So perhaps, need to use __free(kvfree).


  reply	other threads:[~2026-01-16 11:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16  7:48 [PATCH] wifi: rtw89: debug: Fix memory leak in __print_txpwr_map() Zilin Guan
2026-01-16  8:23 ` Zong-Zhe Yang
2026-01-16 12:11   ` Zilin Guan
2026-01-16 11:04 ` Markus Elfring
2026-01-16 11:41   ` Zong-Zhe Yang [this message]
2026-01-16 12:38     ` Markus Elfring
2026-01-16 13:48       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acc90353107248b98215847e56bb374b@realtek.com \
    --to=kevin_yang@realtek.com \
    --cc=Markus.Elfring@web.de \
    --cc=jianhao.xu@seu.edu.cn \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=zilin@seu.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox