From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211: fix sband iftype data lookup for AP_VLAN
Date: Thu, 22 Jun 2023 18:07:24 +0200 [thread overview]
Message-ID: <adf8c1b8ea96c0c6ddc12579eacb8d9948440dcf.camel@sipsolutions.net> (raw)
In-Reply-To: <20230622160501.40666-1-nbd@nbd.name>
On Thu, 2023-06-22 at 18:05 +0200, Felix Fietkau wrote:
> Since AP_VLAN interfaces are not pushed to the driver,
>
That's a mac80211 thing though.
> the driver should not
> be expected to register iftype data for them.
> Map them to the regular AP iftype on lookup.
And this is in cfg80211 - not sure that seems right?
OTOH I'd expect no callers with VLAN here, it doesn't really make sense
since they're not a standalone mode that actually has HE/EHT, but still,
seems odd this way?
What's actually calling it? I'm guessing somewhere in mac80211?
johannes
next prev parent reply other threads:[~2023-06-22 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 16:05 [PATCH] cfg80211: fix sband iftype data lookup for AP_VLAN Felix Fietkau
2023-06-22 16:07 ` Johannes Berg [this message]
2023-06-22 16:25 ` Felix Fietkau
2023-06-22 16:41 ` Johannes Berg
2023-06-22 16:50 ` Felix Fietkau
2023-06-22 16:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adf8c1b8ea96c0c6ddc12579eacb8d9948440dcf.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox