public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@kernel.org>,
	Yan-Hsuan Chuang <yhchuang@realtek.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"kernel-dev@igalia.com" <kernel-dev@igalia.com>
Subject: Re: [PATCH] rtw88: add TX power limit support to 114 and 130 channels
Date: Mon, 13 Apr 2026 10:12:43 -0300	[thread overview]
Message-ID: <adzry4z-LLhfor4e@quatroqueijos.cascardo.eti.br> (raw)
In-Reply-To: <f347beb33eb142cba384bbe9378a061c@realtek.com>

On Mon, Apr 13, 2026 at 05:56:17AM +0000, Ping-Ke Shih wrote:
> Thadeu Lima de Souza Cascardo <cascardo@igalia.com> wrote:
> > On Fri, Apr 10, 2026 at 03:56:11AM +0000, Ping-Ke Shih wrote:
> > > Thadeu Lima de Souza Cascardo <cascardo@igalia.com> wrote:
> > > > Though 114 and 130 are not usual channels, they are found in the wild with
> > > > setups using 5350MHz as the center frequency of a 80MHz setup.
> > >
> > > What did the AP setup? channel 114 160MHz?
> > > I wonder why rtw88 can select a not usual channel 114 80MHz.
> > >
> > > Please share your environment setup.
> > >
> > 
> > This is a Mikrotik that uses channel 130 at 80MHz.
> 
> I'm surprised that an AP can work on this not usual channel/bandwidth. 
> Can you change the setting to usual channel/bandwidth? We'd avoid using
> this unsupported channel/bandwidth by [1].
> 

It seems to be "well-known" that some APs do it and it has caused other
issues in other drivers. But it works just fine with a lot of other
drivers. So, I would rather make rtw88 work with that setting, even if it
falls back to 40MHz, for example.

Let me check what happens when using the proposed patch and I will report
back to you.

> > 
> > > >
> > > > rtw88 supports that, but issues a WARNING because it cannot find the TX
> > > > power limit for those channels.
> > >
> > > Actually, rtw88 hardware can't support that, so we are working on patch
> > > to avoid selecting unusual channels. Can it work properly with
> > > the AP after this patch?
> > >
> > 
> > It does work just fine even without the patch. The only issue is the
> > WARNING that is triggered.
> > 
> 
> As internal discussion, hardware doesn't work on channel 130 80M,
> which means connection might be well, but it can't yield expected performance.
> More, the power limit is not really verified on ch130 80M, so we wonder
> that the signal might not in expectation.
> 

The rationale behing my patch was exactly to try to set the power limit to
the lesser one of the adjacent channels. I am not sure that the expected
performance was not achieved. How would you suggest that I verify?

Thanks a lot.
Cascardo.

> By above reasons, we'd avoid using channel 114 and 130.
> 
> [1] https://lore.kernel.org/linux-wireless/20260413053601.13037-1-pkshih@realtek.com/T/#u
> 
> 

  reply	other threads:[~2026-04-13 13:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06 18:41 [PATCH] rtw88: add TX power limit support to 114 and 130 channels Thadeu Lima de Souza Cascardo
2026-04-10  3:56 ` Ping-Ke Shih
2026-04-10 10:15   ` Thadeu Lima de Souza Cascardo
2026-04-13  5:56     ` Ping-Ke Shih
2026-04-13 13:12       ` Thadeu Lima de Souza Cascardo [this message]
2026-04-14  3:57         ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adzry4z-LLhfor4e@quatroqueijos.cascardo.eti.br \
    --to=cascardo@igalia.com \
    --cc=kernel-dev@igalia.com \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox