From: "Reizer, Eyal" <eyalr@ti.com>
To: Kalle Valo <kvalo@codeaurora.org>, John Stultz <john.stultz@linaro.org>
Cc: Ryan Grachek <ryan@edited.us>, Wei Xu <xuwei5@hisilicon.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
Valentin Schneider <Valentin.Schneider@arm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH] arm64: dts: hikey: Define wl1835 power capabilities
Date: Thu, 14 Jun 2018 06:40:05 +0000 [thread overview]
Message-ID: <ae036763950c4c9e80ceccc8c61e78dd@ti.com> (raw)
In-Reply-To: <87tvq6a577.fsf@kamboji.qca.qualcomm.com>
> >> These properties are required for compatibility with runtime PM.
> >> Without these properties, MMC host controller will not be aware
> >> of power capabilities. When the wlcore driver attempts to power
> >> on the device, it will erroneously fail with -EACCES.
> >>
> >> Signed-off-by: Ryan Grachek <ryan@edited.us>
> >
> > Fixes: 60f36637bbbd ("wlcore: sdio: allow pm to handle sdio power")
> > Tested-by: John Stultz <john.stultz@linaro.org>
> > Acked-by: John Stultz <john.stultz@linaro.org>
> >
> > Wei Xu: This fixes a functional regression with wifi on the HiKey
> > board that was introduced in 4.18-rc with commit 60f36637bbbd
> > ("wlcore: sdio: allow pm to handle sdio power").
> >
> > Could you please be sure to queue this for the 4.18-rc ?
>=20
> Adding linux-wireless so that wireless folks are aware of this wlcore
> regression fix as well.
>=20
Actually "cap-power-off-card" is normally included with all .dts files sup=
porting wilink=20
So it should have been there from the start for this board as well.=20
It probably worked without it due to the explicit call to mmc_power_restore=
_host()
that was there as an old workaround for trying to control the power explici=
tly from the
driver which was actually causing other failures on suspend/resume as the m=
mc layer=20
already power the module on resume.
"keep-power-in-suspend" is needed in case of planning to use "WoWLAN":
Iw phy0 wowlan enable....
Best Regards,
Eyal
next prev parent reply other threads:[~2018-06-14 6:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180613151305.17240-1-ryan@edited.us>
[not found] ` <CANcMJZASEDRxaXwdG96nNeEDPrDm_ap5MjhXonEcg=yHZ8F=qg@mail.gmail.com>
2018-06-13 18:53 ` [PATCH] arm64: dts: hikey: Define wl1835 power capabilities Kalle Valo
2018-06-14 6:40 ` Reizer, Eyal [this message]
2018-06-25 21:56 ` John Stultz
2018-06-26 8:25 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae036763950c4c9e80ceccc8c61e78dd@ti.com \
--to=eyalr@ti.com \
--cc=Valentin.Schneider@arm.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ryan@edited.us \
--cc=tony@atomide.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).