Re: [PATCH wireless-next v3 0/4] wifi: brcmfmac: external auth support for Infineon devices

[Arend van Spriel <arend.vanspriel@broadcom.com>]

On 4/29/2025 10:55 AM, Arend Van Spriel wrote:
> On April 29, 2025 10:19:00 AM Peter Robinson <pbrobinson@gmail.com> wrote:
> 
>>>> I will try and find a couple of other devices with an appropriate
>>>> cypress/infineon.
>>>
>>> Thanks for giving the patches a spin. The firmware should have a feature
>>> named sae_ext. I think the one you with iw are indicating same 
>>> support in
>>> general.
>>
>> I am not so sure.

Sorry for the confusion. Damn autocorrect. "Indicating same support" 
should have been "Indicating sae support". SAE offload support means 
that firmware is doing everything, ie. SAE handshake and 4-way handshake 
(if not mistaken). SAE external auth offloads the SAE handshake to 
user-space.

>> RPi4 (BCM4345/6 - 7.45.234 (4ca95bb CY) FWID 01-996384e2)
>>        Supported extended features:
>>                * [ CQM_RSSI_LIST ]: multiple CQM_RSSI_THOLD records
>>                * [ 4WAY_HANDSHAKE_STA_PSK ]: 4-way handshake with PSK
>> in station mode
>>                * [ 4WAY_HANDSHAKE_STA_1X ]: 4-way handshake with
>> 802.1X in station mode
>>                * [ DFS_OFFLOAD ]: DFS offload
>>                * [ SAE_OFFLOAD ]: SAE offload support
>>                * [ 4WAY_HANDSHAKE_AP_PSK ]: AP mode PSK offload support
>>                * [ SAE_OFFLOAD_AP ]: AP mode SAE authentication 
>> offload support

I think you mentioned earlier this one ends with an error. So SAE is not 
working with that firmware despite the claim. How about WPA2? These 
patches should not affect that, but better check if it does not cause a 
regression.

>> Jetson TX1 (BCM4354/1 - fw 7.35.349.104 (775a9ab CY) FWID 01-d55901b0):
>>        Supported extended features:
>>                * [ CQM_RSSI_LIST ]: multiple CQM_RSSI_THOLD records
>>                * [ DFS_OFFLOAD ]: DFS offload
>>
>> So I have different brcmfmac HW reporting different features.
>>
>>> You can check the firmware features in debugfs under
>>> <mount>/ieee80211/phyX/fwcap.
>>
>> I don't get fwcap on either of the above devices:
>>
>> ls /sys/kernel/debug/ieee80211/phy0/
>> fragmentation_threshold  ht40allow_map  long_retry_limit
>> rts_threshold  short_retry_limit
> 
> Ah, yes. My bad. They are only created if CONFIG_BRCMDBG is selected.

Appreciate the help.

Regards,
Arend