From: "Johannes Berg" <johannes@sipsolutions.net>
To: "Reinette Chatre" <reinette.chatre@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net, "Zhu, Yi" <yi.zhu@intel.com>,
"Reinette Chatre" <reinette.chatre@intel.com>
Subject: Re: [PATCH 3/7] iwlwifi: fix priv->iw_mode setting when multiple vif are configured
Date: Thu, 30 Oct 2008 10:18:03 +0100 (CET) [thread overview]
Message-ID: <ae8368d03d2885c4942e2f9876dcaa60.squirrel@secure.sipsolutions.net> (raw)
In-Reply-To: <1225314349-11139-4-git-send-email-reinette.chatre@intel.com>
Reinette Chatre wrote:
> From: Zhu, Yi <yi.zhu@intel.com>
>
> mac80211 supports multiple virtual interfaces for a single device. For
> example, a managed interface (wlan0) and a monitor interface (mon0) can
> exist at the same time. Thus priv->iw_mode is not sufficient to track
> the wireless mode any more.
This example is not correct, mac80211 will only support multiple virtual
interfaces when the driver allows this via add_interface (which I don't
think yours does) and it will *never* tell you about monitor interfaces at
all except by way of configuring the filter differently.
Therefore, all the "is monitor" checks in iwlwifi are pretty pointless
unless you really want to have differing behaviour between "monitor +
something" and "just monitor"?
johannes
next prev parent reply other threads:[~2008-10-30 9:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 21:05 [PATCH 0/7] iwlwifi driver updates Reinette Chatre
2008-10-29 21:05 ` [PATCH 1/7] iwlwifi: reorganize flow handler bitology Reinette Chatre
2008-10-29 21:05 ` [PATCH 2/7] iwlwifi: trivial removal of some 4965 remaining from iwl-agn-rs.h Reinette Chatre
2008-10-29 21:05 ` [PATCH 3/7] iwlwifi: fix priv->iw_mode setting when multiple vif are configured Reinette Chatre
2008-10-29 21:05 ` [PATCH 4/7] iwlwifi: rename generic iwlagn functions that had a HW specific name Reinette Chatre
2008-10-29 21:05 ` [PATCH 5/7] iwlwifi: rename double inclusion protection name in iwl-commands.h Reinette Chatre
2008-10-29 21:05 ` [PATCH 6/7] iwlwifi: iwl-agn-rs: initialize rs with valid antenna Reinette Chatre
2008-10-29 21:05 ` [PATCH 7/7] iwlwifi: do not call statistics from rfkill Reinette Chatre
2008-10-30 9:18 ` Johannes Berg [this message]
2008-11-05 0:09 ` [PATCH 3/7] iwlwifi: fix priv->iw_mode setting when multiple vif are configured Zhu Yi
2008-11-05 11:27 ` Johannes Berg
2008-11-06 2:34 ` Zhu Yi
2008-11-06 10:39 ` Johannes Berg
2008-11-07 8:04 ` Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae8368d03d2885c4942e2f9876dcaa60.squirrel@secure.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).