From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED2072949E0; Mon, 27 Apr 2026 07:00:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777273233; cv=none; b=eZaHhYGQOiHz4fXdNgEe5p2M2YEfCUs1dBicQbrjw6qprWrj3abhF56jcrZNMNOeIyRvZhlkiklbmrRLsL3RE4Syz7JFA0Q/6x4I4cvWNF9QzEbBnlLGqS/J6Onk8I+TcMAUMT6z5maTEIVzpLFPzXm4koCQjeUg16ZAkywZiIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777273233; c=relaxed/simple; bh=hscgZXrH/5hlVlI4joz/OwlsC/ItzGkqY+r3g/tMh6g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X/jOnALYSNxnCTEtifFIBqo/tpRhGzeo9PPVrPmCS3oULZniRMne/N7rG7vjU51aOgmj4JGSPJL5/EHB/W8H6D6/lAMDv+PbGOhIAAtSafGXuPs7YLlzgTGEMjIs/sPfE5QaJ10pLr99X4HJGkiWdkhg5jx239miPEDt+FTjFTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r/UO8nr5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r/UO8nr5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A383C2BCB8; Mon, 27 Apr 2026 07:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777273232; bh=hscgZXrH/5hlVlI4joz/OwlsC/ItzGkqY+r3g/tMh6g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r/UO8nr5TQ7PliWjUKlAZqvmtgQU+FEMkbRmmSgrIX7+9ZgK/HIdX4NYWVZ4rngKw PLBQ0/wMFxTjBXytc8sMx2PcAaIJUCNUNus9UpAS0DhvvpIolB2CfnSbt8y6g3u783 4e6eNxqixT4kTNhHFlxBIuqeVX3NZhfdHxj4Z+nudtcjnondSnBuoupFAF3EdjoALF 56TK9X9uH+Uv7gDR6L3FJ17myhK+nPEb2Xzx7pPVYCMqiKLog4QTEgJPM54KXGoI5h b0RP6hj3HJCTnvpSJs4bTwtNGexQKcRoLqkpcafByY/22j7sIulWa9Q1ER6iZY0/q5 ceI/MVWjDbmJw== Date: Mon, 27 Apr 2026 09:00:30 +0200 From: Lorenzo Bianconi To: Rosen Penev Cc: linux-wireless@vger.kernel.org, Felix Fietkau , Ryder Lee , Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , "open list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH wireless-next] wifi: mt76: fix of_get_mac_address error handling Message-ID: References: <20260427051746.954704-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VmDJMRbZHv0Lzy9p" Content-Disposition: inline In-Reply-To: <20260427051746.954704-1-rosenp@gmail.com> --VmDJMRbZHv0Lzy9p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Check return value instead of is_valid_ether_addr. The latter is handled > by the former. >=20 > Signed-off-by: Rosen Penev Acked-by: Lorenzo Bianconi > --- > drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wi= reless/mediatek/mt76/eeprom.c > index 93d91264687f..0f6ccf6ed53d 100644 > --- a/drivers/net/wireless/mediatek/mt76/eeprom.c > +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c > @@ -93,7 +93,7 @@ mt76_eeprom_override(struct mt76_phy *phy) > if (err =3D=3D -EPROBE_DEFER) > return err; > =20 > - if (!is_valid_ether_addr(phy->macaddr)) { > + if (err) { > eth_random_addr(phy->macaddr); > dev_info(dev->dev, > "Invalid MAC address, using random address %pM\n", > --=20 > 2.54.0 >=20 --VmDJMRbZHv0Lzy9p Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCae8JjgAKCRA6cBh0uS2t rBXWAP9XbNiVEDpyQr3wYwK6yy95P7sLbl7oGeiTS3olm3X2sQEAn6TCQaIm/1uu vNVMiJbIVrmUHHeTG560ExFWwjBmTQQ= =lAlv -----END PGP SIGNATURE----- --VmDJMRbZHv0Lzy9p--