Re: [PATCH v7 2/3] dt-bindings: net: wireless: mt76: add more PCI devices

[Krzysztof Kozlowski <krzk@kernel.org>]

On 17/02/2026 13:59, Ryder Lee wrote:
> On Tue, 2026-02-17 at 08:48 +0100, Krzysztof Kozlowski wrote:
>> On Mon, Feb 16, 2026 at 08:01:15AM -0800, Ryder Lee wrote:
>>> This adds support for mt7915/mt7916/mt7990/mt7992/mt7996 PCI
>>> devices.
>>
>> No, it does not add any support. I asked you to provide rationale why
>> this is needed.
>>
>> Also, read submitting patches finally - it is not "This adds...".
> 
> Are you referring to this - Describe your changes in imperative mood...

Yes

> So, what would you like me to describe this change? what about this
> "Add platform IDs for known devices"?

First comment - provide rationale why discoverable devices needs to be
described in non-discoverable way...


> 
>>
>>>
>>> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
>>> ---
>>> v7: add missing dts mailing list and maintainers
>>
>> No, you still did not bother to Cc maintainers. I gave you detailed
>> instruction which you just ignored.
>>
>> Best regards,
>> Krzysztof
>>
> 
> Oh, I used to do it this way. But aren’t you all on the devicetree
> mailing list?

No, I am not. None of us supposed to be anymore, although we can use
korgalore to achieve same result. Patchwork is on DT list, but the docs
still ask you to send to the maintainers directly and maintainers
organized their workflow around this.

> I did notice that running get_maintainer added some more people.
> I’ll include all dts maintainers as well.

Best regards,
Krzysztof