From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE49A125AA for ; Tue, 28 Apr 2026 17:12:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777396335; cv=none; b=A5paKhhBrvVP3+CRBgLgA955gzB4iNDQVsJcnjgXev+1gOXl09hqaNNwch7I/dG7aO6nRbgmIctkcRtTEa9f7Gk05Q4VLyAnhR/8S8qNItWafQ5bSsvVTzx/KqnOviVbJZwWFxyX7RcVuPIsTwWtw+R87gsU+KDFWo7RsXj2Kqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777396335; c=relaxed/simple; bh=31OmypALgw6Aq6kNGR9mt8YsQuZjcj+PgdNPgtmbOX0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cG5E+5r1qSFoo2As61m75YruBgTv131dhygrM1ykZix6YMKe1jL0gP1Z2dghnjVv3pOIbF7zqPTicrwOqv3oLS9IsFWC+yOkZ+cOBmSk5afNcPWYgnaocAZuPSqU2GEScCPmcuvrRJkOE/9WzTBnHiNQ0HFAgO7I9JEwCWkVxno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kJDDRvoT; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kJDDRvoT" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-38e936caafeso119729571fa.2 for ; Tue, 28 Apr 2026 10:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777396332; x=1778001132; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VPcsAOQUvm2NFAOixpYW914de8cadeaU2Eu3SiUW0yA=; b=kJDDRvoTYfF+vWyZu5U6Zq/tLwm5enQa1I9UQaH/bboZDlXgdpvUy9+OzHl66cIRTT viz4eDxuiOFzYLuDL1MiW0pOG949Oi6A8Sg3AcWr+c3+e75viNkUEP2M/9nCOUfU4n/j bPDyHMBouJqz5QnlunDXbLTUe0Ox/1zIr7C0ZJUYybDAt8V9a3OFtsIGVSVyemMnDoEL QnoNU7SanjB/Nacfa0w3rn6VDwXpZGbJzOMjjAyuXQyxJCJbzuJfUqFXlGuE27NAR6V/ hD3tY9v3VgCBYqR0mZzBjlnbS7MEjX+/mPd7lf1whdCSR/LrKvH6mqcm/y7YMkO3cHYx ERzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777396332; x=1778001132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VPcsAOQUvm2NFAOixpYW914de8cadeaU2Eu3SiUW0yA=; b=EJktfeZL/MLE/624AxRtEZN+5nquX0ANCgeMU8BDpXboxRTFlqQ6MfoAEq7jllRBas asH2Ufu4C9XuKzXQv8m8LFby7Db83R6mf8my/VTSMvnDzG0d2C4NwTYRWyWuG1Yf9L85 WScXwiHs+8MSy+FOj7iVpsjQtSwjzu9W5gZZUHmtRUhgvr/p4xX8U6aszw8+AaPppaZh hL2fFkwb0FOsB5lQO0x8WgmdMpb+4Q+yye66tXXTCG7swDeLNjzD5DbFd7n7MR/H9u64 jtI3qQ3ru8K22w3Rjci/zIj8JMaWswAD4gW37sccQCSsCw6Os6UT2oHK0K/e7c4JnbmN EDEg== X-Gm-Message-State: AOJu0YyNzocyjtdJBNBx5xLEJ4SJljSa8n70l6VmhL9PQo+OfKDWZLPa sC2JmeSYiMxBHOF56USXBbI3lBTw7h0U8nZMkifY2F+nAm87DvVhsnILFK3iNg== X-Gm-Gg: AeBDietpNtf3KUYbT5AKoMdgYT84Nuk8tWntXkmvICyG5uVMM7Ii261qY9zDERpe4ix 2CruJdVMR4pMpmmVXbYFI2FBJmvLjiQPf+9ARk5TTxaJllkLjXynoqsNPh8DpYMrRcEVdN4NZKF mATxWdF2k+GLs7kB4FSy1vg4y0jnF7eBvE21sJ9RGyCf/P+xciDa23kUPc/NVgFcSiUmdIl7dBr j6LE++KAFbe5HSlRDas+NVUyt28wtQuICc8uhTz0OZa1Gl6n0c1o1R5Jls4sXsXY1gK4hHuEcZn bgDbyJ2hCC+I3bwhH5MhBNVqk64aX8sFvE3AHJY5jpDxrI04UvZ3xh4jD+gOgvIF1SRrgi0MXdy EFqnSA+aeeAPNvSnbOI6QNsmsjVqsGBaoSCv/p/hUGNWuKC4ZvCeRq8AbJ7NjxLDLRub+tN+trO WWuEnb04EjtxeSthSr6x7xkAtK3KUTh3T5I0nDxPELzWzc8d+GVoCE4or1IvaWzkYBd0TvmLUUp c+aF0XStGd4 X-Received: by 2002:a05:6512:118c:b0:5a4:6a5:9900 with SMTP id 2adb3069b0e04-5a74662a687mr1854102e87.34.1777396331610; Tue, 28 Apr 2026 10:12:11 -0700 (PDT) Received: from Thor.home (nb6bp2luucgh1ubvhqb-1.v6.elisa-laajakaista.fi. [2001:99a:a58:9b00:9119:221d:45f0:de83]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a746408102sm752262e87.70.2026.04.28.10.12.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 10:12:11 -0700 (PDT) Date: Tue, 28 Apr 2026 20:12:09 +0300 From: Maxin John To: Johannes Berg Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH] iw: Makefile: support out-of-tree builds Message-ID: References: <20260423113154.1070521-1-maxin.john@gmail.com> <1672e78507b643f4610265f018ccddcb141ee726.camel@sipsolutions.net> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1672e78507b643f4610265f018ccddcb141ee726.camel@sipsolutions.net> Hi Johannes, Thanks for the review comments. On Mon, Apr 27, 2026 at 11:43:54AM +0200, Johannes Berg wrote: > On Thu, 2026-04-23 at 14:31 +0300, Maxin John wrote: > > Enable out-of-tree builds without modifying the source tree. > > Out-of-tree builds are required by build frameworks such as OpenEmbedded. > > You should probably say how this is intended to be used, clearly not in > the O= way that the kernel has, for example. I will clarify the intended usage in the next iteration. > > +SRCDIR := $(dir $(lastword $(MAKEFILE_LIST))) > > That doesn't work if there's whitespace anywhere along the path. > > > +CPPFLAGS += -I$(SRCDIR) > > +CPPFLAGS += -I. > > The "-I." seems questionable since you evidently intend to have "." > *not* be the source dir? The -I. was intended to ensure that generated files such as nl80211-commands.inc, which are produced in the build directory, remain discoverable by the compiler. Agree that it doesn't look right and I will update it. > > Overall it might be simpler to actually do it with the kernel-style O= > so you just need to change all the outputs, rather than all the inputs? Got it. I will update it as per your comments and send a v2. > > johannes Best Regards, Maxin