Re: [PATCH 1/5] wifi: mt76: usb: size RX page-pool pages from queue buffer

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]

> From: Sean Wang <sean.wang@mediatek.com>
> 
> Use the RX queue buffer size to select the page-pool allocation order.
> This lets USB devices use larger RX buffers without silently allocating
> undersized order-0 pages.
> 
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mac80211.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mac80211.c b/drivers/net/wireless/mediatek/mt76/mac80211.c
> index 13c4e8abe281..6ff1eada6d09 100644
> --- a/drivers/net/wireless/mediatek/mt76/mac80211.c
> +++ b/drivers/net/wireless/mediatek/mt76/mac80211.c
> @@ -628,6 +628,9 @@ int mt76_create_page_pool(struct mt76_dev *dev, struct mt76_queue *q)
>  	if (!is_qrx && !mt76_queue_is_wed_tx_free(q))
>  		return 0;
>  
> +	if (q->buf_size > PAGE_SIZE)
> +		pp_params.order = get_order(q->buf_size);

I guess you are interested just in usb devices here, right? Moreover, are you
interested just in MT_RXQ_MAIN queue?

Regards,
Lorenzo

> +
>  	switch (idx) {
>  	case MT_RXQ_MAIN:
>  	case MT_RXQ_BAND1:
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]