From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Bo.Jiao@mediatek.com, angelogioacchino.delregno@collabora.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-wireless@vger.kernel.org, matthias.bgg@gmail.com,
nbd@nbd.name, rex.lu@mediatek.com, ryder.lee@mediatek.com,
sean.wang@mediatek.com, shayne.chen@mediatek.com,
sujuan.chen@mediatek.com
Subject: Re: [PATCH mt76 v5 16/16] wifi: mt76: mt7996: Add SW path for HW-RRO v3.1
Date: Wed, 15 Jul 2026 09:46:14 +0200 [thread overview]
Message-ID: <alc6xTe4uPIJHQy8@lore-desk> (raw)
In-Reply-To: <20260715070001.1503928-1-amadeus@jmu.edu.cn>
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
> Hi,
Hi Chukun,
>
> > + if (dev->mt76.hwrro_mode == MT76_HWRRO_V3_1) {
> > + /* rxdmad_c */
> > + mdev->q_rx[MT_RXQ_RRO_RXDMAD_C].flags = MT_WED_RRO_Q_RXDMAD_C;
>
> This introduces the RRO_Q_RXDMAD_C flag for the MT7992 chipset.
> However, the mt76_wed_dma_setup function lacks handling for
> MT76_WED_RRO_Q_RXDMAD_C, causing it to return -EINVAL:
>
> [ 20.049167] mt7996e 0000:01:00.0: attaching wed device 0 version 3
> [ 20.114412] platform 15010000.wed: MTK WED WO Firmware Version: ..
> [ 20.123728] platform 15010000.wed: MTK WED WO Chip ID 00 Region 2
> [ 20.965401] mt7996e 0000:01:00.0: probe with driver mt7996e failed with error -22
>
> Can you fix this?
IIRC WED is not supported for HW RRO3.1 at the moment, it is not just a matter of
fixing mt76_wed_dma_setup().
Regards,
Lorenzo
>
> Thanks,
> Chukun
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-07-15 7:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 9:45 [PATCH mt76 v5 00/16] wifi: mt76: mt7996: Decouple RRO logic from WED support Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 01/16] wifi: mt76: Add reset_idx to reset_q mt76_queue_ops signature Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 02/16] wifi: mt76: Remove q->ndesc check in mt76_dma_rx_fill() Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 03/16] wifi: mt76: Differentiate between RRO data and RRO MSDU queues Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 04/16] wifi: mt76: Do not always enable NAPIs for WED RRO queues Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 05/16] wifi: mt76: mt7996: Initial DMA configuration for MT7992 WED support Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 06/16] wifi: mt76: mt7996: Enable HW RRO for MT7992 chipset Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 07/16] wifi: mt76: mt7996: Introduce the capability to reset MT7992 WED device Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 08/16] wifi: mt76: mt7996: Fix tx-queues initialization for second phy on mt7996 Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 09/16] wifi: mt76: mt7996: Fix RX packets configuration for primary WED device Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 10/16] wifi: mt76: mt7996: Enable WED for MT7992 chipset Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 11/16] wifi: mt76: mt7996: Convert mt7996_wed_rro_addr to LE Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 12/16] wifi: mt76: mt7996: Introduce RRO MSDU callbacks Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 13/16] wifi: mt76: Add rx_queue_init callback Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 14/16] wifi: mt76: mt7996: Decouple RRO logic from WED support Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 15/16] wifi: mt76: Add mt76_dma_get_rxdmad_c_buf utility routione Lorenzo Bianconi
2025-09-09 9:45 ` [PATCH mt76 v5 16/16] wifi: mt76: mt7996: Add SW path for HW-RRO v3.1 Lorenzo Bianconi
2026-07-15 7:00 ` Chukun Pan
2026-07-15 7:46 ` Lorenzo Bianconi [this message]
2026-07-15 9:00 ` Chukun Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alc6xTe4uPIJHQy8@lore-desk \
--to=lorenzo@kernel.org \
--cc=Bo.Jiao@mediatek.com \
--cc=amadeus@jmu.edu.cn \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=rex.lu@mediatek.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=sujuan.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox