Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Björn Smedman" <bjorn.smedman@venatech.se>
To: linville@tuxdriver.com, johannes@sipsolutions.net,
	lrodriguez@atheros.com
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 0/3] Fix rate control for A-MPDU
Date: Sun, 10 Oct 2010 22:05:27 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1010102203230.31264@bigbill> (raw)

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1317 bytes --]

Hi all,

Rate control for A-MPDU is somewhat complicated, mainly because each 
subframe has its own tx status but rate control is only relevant on a per 
aggregate level. This patch series fixes some more obscure bugs in the 
rate control feedback for A-MPDU frames, mainly for the case when rate 
control feedback is carried on a frame that has failed transmission.

There are two underlying assumptions: (1) the ampdu_len and ampdu_ack_len 
fields of the tx status structure must be set correctly by the driver if 
the IEEE80211_TX_STAT_AMPDU flag is set, and (2) the value of these fields 
must not be relied upon by rate control if the flag is not set.

I've only been able to test these patches with the ath9k driver using 
the minstrel ht rate control algorithm. I have also looked at the other 
driver references to ampdu_len and they seem safe under the above 
assumptions, except ath9k's built in rate control, for which I've 
attempted a fix.

Björn Smedman (3):
 mac80211: minstrel_ht A-MPDU fix
 ath9k: A-MPDU rate control info fix
 ath9k: built-in rate control A-MPDU fix

 drivers/net/wireless/ath/ath9k/rc.c   |    6 ++++++
 drivers/net/wireless/ath/ath9k/xmit.c |   19 +++++++++++++------
 net/mac80211/rc80211_minstrel_ht.c    |    7 ++++---
 3 files changed, 23 insertions(+), 9 deletions(-)

/Björn

                 reply	other threads:[~2010-10-10 20:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1010102203230.31264@bigbill \
    --to=bjorn.smedman@venatech.se \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox