From: Julia Lawall <julia.lawall@lip6.fr>
To: Joe Perches <joe@perches.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version()
Date: Sun, 20 Dec 2015 20:00:02 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1512201959090.2055@localhost6.localdomain6> (raw)
In-Reply-To: <1450637228.3430.30.camel@perches.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1063 bytes --]
On Sun, 20 Dec 2015, Joe Perches wrote:
> On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote:
> > There is a type bug so it always returns success.
>
> How many false positives do you have to sift
> through to find this sort of error?
The return type is thoughtfully bool, so it should be easy in this case.
The function has a return -EINVAL and a return true, so even without the
return type it would be locally apparent that there is an inconsistency.
julia
>
> > +++ b/drivers/net/wireless/ath/ath9k/eeprom.c
> > @@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(struct ath_hw *ah, int version, int minrev)
> > ath_err(common, "Bad EEPROM VER 0x%04x or REV 0x%04x\n",
> > ah->eep_ops->get_eeprom_ver(ah),
> > ah->eep_ops->get_eeprom_rev(ah));
> > - return -EINVAL;
> > + return false;
> > }
> >
> > return true;
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-12-20 19:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 10:59 [patch -next] ath9k: fix ath9k_hw_nvram_check_version() Dan Carpenter
2015-12-19 11:12 ` Martin Blumenstingl
2015-12-20 18:47 ` Joe Perches
2015-12-20 19:00 ` Julia Lawall [this message]
2015-12-20 19:05 ` Joe Perches
2015-12-20 20:33 ` Dan Carpenter
2016-01-07 13:05 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1512201959090.2055@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox