From: Julia Lawall <julia.lawall@lip6.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Joe Perches <joe@perches.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Jes Sorensen <Jes.Sorensen@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: rtl8723au: incorrect use of ether_addr_copy()
Date: Wed, 8 Oct 2014 14:50:50 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1410081449160.2441@hadrien> (raw)
In-Reply-To: <20141008124631.GC26918@mwanda>
On Wed, 8 Oct 2014, Dan Carpenter wrote:
> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
> > On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
> > > The return from myid() isn't aligned correctly for ether_addr_copy().
> >
> > Hey Dan.
> >
> > Actual evidence showing ether_addr_copy conversions
> > may not always be wise.
> >
> > How did you find them?
>
> I was just trying to see how common these kinds of bugs are. It didn't
> take long to find, but my impression is that they are rare and I got
> lucky. These kinds of bugs are tricky to find and we don't have any
> tools for it.
Couldn't you just use your favorite matching tool, collect the file names,
compile them, run pahole, and process the output in some way? It doesn't
give a complete analysis (you don't find all problems), but if you find a
problem it is a real problem.
julia
next prev parent reply other threads:[~2014-10-08 12:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 10:40 [patch] staging: rtl8723au: incorrect use of ether_addr_copy() Dan Carpenter
2014-10-08 12:26 ` Joe Perches
2014-10-08 12:46 ` Dan Carpenter
2014-10-08 12:50 ` Julia Lawall [this message]
2014-10-08 13:17 ` Dan Carpenter
2014-10-08 14:22 ` Joe Perches
2014-10-08 14:33 ` Jes Sorensen
2014-10-08 14:51 ` Joe Perches
2014-10-08 15:09 ` Jes Sorensen
2014-10-08 13:59 ` Jes Sorensen
2014-10-08 14:24 ` Dan Carpenter
2014-10-08 14:32 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1410081449160.2441@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox