From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:37309 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbdBBOGW (ORCPT ); Thu, 2 Feb 2017 09:06:22 -0500 Date: Thu, 2 Feb 2017 15:06:10 +0100 (CET) From: Julia Lawall To: Felix Fietkau cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org, kbuild-all@01.org Subject: [PATCH] mt76: fix debugfs_simple_attr.cocci warnings Message-ID: (sfid-20170202_150626_394049_C7B15FFB) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci CC: Felix Fietkau Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- I'm just passing this along. I don't personally know anything about this issue. debugfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/net/wireless/mediatek/mt76/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/debugfs.c @@ -33,7 +33,8 @@ mt76_reg_get(void *data, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(fops_regval, mt76_reg_get, mt76_reg_set, "0x%08llx\n"); +DEFINE_DEBUGFS_ATTRIBUTE(fops_regval, mt76_reg_get, mt76_reg_set, + "0x%08llx\n"); static int mt76_queues_read(struct seq_file *s, void *data) @@ -64,8 +65,8 @@ struct dentry *mt76_register_debugfs(str return NULL; debugfs_create_u32("regidx", S_IRUSR | S_IWUSR, dir, &dev->debugfs_reg); - debugfs_create_file("regval", S_IRUSR | S_IWUSR, dir, dev, - &fops_regval); + debugfs_create_file_unsafe("regval", S_IRUSR | S_IWUSR, dir, dev, + &fops_regval); debugfs_create_blob("eeprom", S_IRUSR, dir, &dev->eeprom); if (dev->otp.data) debugfs_create_blob("otp", S_IRUSR, dir, &dev->otp);