From: Linus Torvalds <torvalds@linux-foundation.org>
To: Michael Buesch <mb@bu3sch.de>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
"John W. Linville" <linville@tuxdriver.com>,
"David S. Miller" <davem@davemloft.net>,
wireless <linux-wireless@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: Make b43 driver fall back gracefully to PIO mode after fatal DMA errors
Date: Fri, 26 Feb 2010 12:42:29 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.1002261239070.4513@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.1002261231320.4513@localhost.localdomain>
On Fri, 26 Feb 2010, Linus Torvalds wrote:
>
> So send me a patch. I'll try it. But I have no hardware docs, nor any
> information about how that SSB bridge is supposed to work, or why DMA
> might be failing.
Btw, I also object to your argument that
"Well, my original plan was to get rid of controller_restart and not add
yet another user of it, because it is extremely broken and racy. The
locking in the whole driver is completely braindead due to the mere
existence of this function."
is a reason to not apply the patch. The patch makes the driver _work_. Not
on some odd-ball hardware either, but a regular Dell laptop.
So if you have a patch to remove controller_restart, I'm sure I can modify
mine to work on top of such a new world order. But if you do _not_ have
such a patch, then that is no argument for keeping the driver in a
known-broken state.
The fact that the driver locking is odd is _not_ a reason to not fix other
issues that are totally unrelated to locking.
Linus
next prev parent reply other threads:[~2010-02-26 20:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.00.1002261034140.4513@localhost.localdomain>
2010-02-26 19:09 ` Make b43 driver fall back gracefully to PIO mode after fatal DMA errors Larry Finger
2010-02-26 19:13 ` Linus Torvalds
2010-02-26 20:06 ` Linus Torvalds
2010-02-26 20:09 ` Gábor Stefanik
2010-02-26 20:50 ` Linus Torvalds
2010-02-26 21:01 ` Larry Finger
2010-02-26 21:45 ` Linus Torvalds
2010-02-26 21:50 ` Linus Torvalds
2010-02-26 22:08 ` Gábor Stefanik
2010-02-26 22:46 ` Linus Torvalds
2010-02-26 22:54 ` Gábor Stefanik
2010-02-27 15:04 ` Michael Buesch
2010-02-27 14:59 ` Michael Buesch
2010-02-27 18:31 ` Linus Torvalds
2010-02-27 18:51 ` Michael Buesch
2010-02-26 19:59 ` Michael Buesch
2010-02-26 20:07 ` Linus Torvalds
2010-02-26 20:20 ` Michael Buesch
2010-02-26 20:33 ` Linus Torvalds
2010-02-26 20:42 ` Linus Torvalds [this message]
2010-02-27 14:44 ` Michael Buesch
2010-02-27 14:49 ` Michael Buesch
2010-02-27 17:36 ` Michael Buesch
2010-02-27 20:12 ` Nathan Schulte
2010-02-27 21:08 ` Linus Torvalds
2010-02-27 21:43 ` Michael Buesch
2010-02-27 22:12 ` Linus Torvalds
2010-02-26 20:46 Nathan Schulte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1002261239070.4513@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox