From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:39814 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752399AbZERPfZ (ORCPT ); Mon, 18 May 2009 11:35:25 -0400 Date: Mon, 18 May 2009 08:32:18 -0700 (PDT) From: Linus Torvalds To: Ingo Molnar cc: Oleg Nesterov , "Rafael J. Wysocki" , Jonathan Corbet , Martin Bammer , Jeff Garzik , Kumar Gala , Andrew Morton , Linux Kernel Mailing List , Adrian Bunk , Natalie Protasevich , Kernel Testers List , Network Development , Linux ACPI , Linux PM List , Linux SCSI List , Linux Wireless List , DRI Subject: Re: 2.6.30-rc6: Reported regressions from 2.6.29 In-Reply-To: <20090518151102.GA6241@elte.hu> Message-ID: References: <_AjETDMbIoL.A.DcH.RYzDKB@chimera> <20090517073327.GC1583@elte.hu> <20090518145725.GB18607@redhat.com> <20090518151102.GA6241@elte.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 18 May 2009, Ingo Molnar wrote: > > Btw., why did the patch (and the revert) make any difference to the > test? Timing differences look improbable. It's the change from !signal_group_exit(signal) to !sig_kernel_only(signr) and quite frankly, I still don't see the point. The comment seems to be wrong too: If SIGSTOP/SIGKILL originate from a descendant of container-init they are never queued (i.e dropped in sig_ignored() in an earler patch). If SIGSTOP/SIGKILL originate from parent namespace, the signal is queued and container-init processes the signal. since the bug was that the SIGSTOP (from within the same container) was _not_ ignored like the comment says. Linus