From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: devel@driverdev.osuosl.org, ath9k-devel@venema.h4ckr.net,
Jeff Garzik <jeff@garzik.org>,
linux-wireless@vger.kernel.org,
Nick Kossifidis <mickflemm@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 3/4] ath5k: define ath_common ops
Date: Fri, 11 Sep 2009 13:11:45 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0909111308120.3654@localhost.localdomain> (raw)
In-Reply-To: <43e72e890909111043m78411058i86e61909a35412f@mail.gmail.com>
On Fri, 11 Sep 2009, Luis R. Rodriguez wrote:
>
> > In fact, if you know what kind of IO op it is (ie "it's always MMIO"),
> > you'd be even better using "writel()" directly,
>
> Heh.. you realize I tried to document such a thing a while ago and it
> seems you opposed it [1]?
If it's mapped with "pci_iomap()" you should use ioread*/iowrite*.
But if you know it's always MMIO, and you use just ioremap() to map it,
and then readl/writel.
It's the _mixing_ of the two that I object to:
- pci_iomap() - can do either MMIO of PIO
- readl/writel - always just MMIO
should preferably not be mixed.
(Sure it will _work_, but I wouldn't encourage it)
Linus
next prev parent reply other threads:[~2009-09-11 20:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 1:34 [PATCH 0/4] atheros: implement common read/write ops Luis R. Rodriguez
2009-09-11 1:34 ` [PATCH 1/4] atheros/ath9k: add common read/write ops and port ath9k to use it Luis R. Rodriguez
2009-09-11 1:34 ` [PATCH 2/4] ath5k: allocate ath5k_hw prior to initializing hw Luis R. Rodriguez
2009-09-11 1:34 ` [PATCH 3/4] ath5k: define ath_common ops Luis R. Rodriguez
2009-09-11 1:42 ` Bob Copeland
2009-09-11 1:46 ` Luis R. Rodriguez
2009-09-11 6:16 ` Nick Kossifidis
2009-09-11 6:46 ` Jiri Slaby
2009-09-11 7:23 ` Luis R. Rodriguez
2009-09-11 11:35 ` Bob Copeland
2009-09-11 17:53 ` Luis R. Rodriguez
2009-09-11 14:24 ` Linus Torvalds
2009-09-11 17:43 ` Luis R. Rodriguez
2009-09-11 20:11 ` Linus Torvalds [this message]
2009-09-12 11:53 ` Jiri Slaby
2009-09-13 0:56 ` Luis R. Rodriguez
2009-09-11 1:34 ` [PATCH 4/4] atheros: define shared bssidmask setting Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0909111308120.3654@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=devel@driverdev.osuosl.org \
--cc=jeff@garzik.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox