From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: if i deselect PCIEPORTBUS, why are iwlwifi PCIE modules still being compiled?
Date: Tue, 20 May 2014 05:28:46 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.11.1405200526530.12158@localhost> (raw)
In-Reply-To: <1400574452.4474.2.camel@jlt4.sipsolutions.net>
On Tue, 20 May 2014, Johannes Berg wrote:
> On Tue, 2014-05-20 at 03:49 -0400, Robert P. J. Day wrote:
> > quite possibly a silly question (which has never stopped me before),
> > but in perusing the PCIE code in the kernel source, i was looking for
> > sample code to demo in a classroom setting and picked on
> > drivers/net/wireless/iwlwifi/pcie, which i was *assuming* was
> > PCIE-dependent -- specifically, i was going to demo the Advanced-N
> > 6235 PCIE wifi card on an intel galileo board.
> >
> > but i thought it was a bit strange that the pcie/ subdirectory there
> > doesn't seem to depend on PCIEPORTBUS. as a test, i deselected
> > PCIEPORTBUS in a configuration and did a rebuild, and the source in
> > the pcie/ directory was recompiled.
> >
> > am i misunderstanding the function of the kernel config variable
> > PCIEPORTBUS? i notice that .../iwlwifi/Makefile includes the line:
> >
> > iwlwifi-objs += pcie/drv.o pcie/rx.o pcie/tx.o pcie/trans.o
> >
> > which simply compiles those files with no regard to dependency. can
> > someone clarify this? thanks.
>
> The whole driver depends on CONFIG_PCI, maybe it should depend on
> something more PCIe specific, but that wasn't easy to sort out, and
> the APIs it needs aren't PCIe specific afaict.
ok, i'll have to think about that for a few minutes. am i at least
correct in my understanding that, technically, the kernel config
option PCIEPORTBUS is supposed to control whether one wants basic PCIE
support or not?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next prev parent reply other threads:[~2014-05-20 9:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 7:49 if i deselect PCIEPORTBUS, why are iwlwifi PCIE modules still being compiled? Robert P. J. Day
2014-05-20 8:27 ` Johannes Berg
2014-05-20 9:28 ` Robert P. J. Day [this message]
2014-05-20 10:20 ` Johannes Berg
2014-05-20 10:26 ` Robert P. J. Day
2014-05-20 9:34 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1405200526530.12158@localhost \
--to=rpjday@crashcourse.ca \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).