From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpo49.interia.pl (smtpo49.interia.pl [217.74.67.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8E30442B08 for ; Mon, 7 Sep 2026 09:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.74.67.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788774567; cv=none; b=REuRXU6BlXpgE02K1+HQfuFEURWGnzWRbYXhByfjzKZjcBDz9wKOLmmuiYtVxt2ISGEt5Tu9NoW1xE4ydYtHNmSoB9VHhkASsB9DxcrFhQljsk363fWhGaVLPLg87Qp3eF5dePUT+yIrL/sobZjFMnaJYvvDGoJ8JwaCDSU81Ao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788774567; c=relaxed/simple; bh=NcIZPAEXx+xGpOzOy3HmqtQivZXN0toLyO/bs9gO084=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PecoWb6ibEVMNIp5pZjDAn8s6eJvmmy9VzNrx19yT5SNh1xgKMokfL+Ympf2LJCDtISUq19xmh6KdxtFEjS6V3lOs/ObOSJ4C0wJvRFbBLe2kF7bqCbLYLUYF1mcvKzqVQNLmcoLw0dwBekGhlvnOWX8YdMd4v0L5FkhpfiDJqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=poczta.fm; spf=pass smtp.mailfrom=poczta.fm; dkim=pass (1024-bit key) header.d=poczta.fm header.i=@poczta.fm header.b=YRxWttTd; arc=none smtp.client-ip=217.74.67.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=poczta.fm Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=poczta.fm Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=poczta.fm header.i=@poczta.fm header.b="YRxWttTd" Received: from nr200 (unknown [80.68.231.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by poczta.interia.pl (INTERIA.PL) with ESMTPSA; Mon, 7 Sep 2026 11:46:24 +0200 (CEST) Date: Mon, 7 Sep 2026 11:46:21 +0200 From: Slawomir Stepien To: Johannes Berg Cc: syzkaller-bugs@googlegroups.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot@lists.linux.dev, syzbot+9bdc0c5998ab45b05030@syzkaller.appspotmail.com Subject: Re: [PATCH 3/3] wifi: cfg80211: check if AP has been started before adding new station Message-ID: References: <20260813090434.2071318-1-sst@poczta.fm> <20260813090434.2071318-3-sst@poczta.fm> <113768c35523738bdc7ab8441ecda64a063900bf.camel@sipsolutions.net> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <113768c35523738bdc7ab8441ecda64a063900bf.camel@sipsolutions.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poczta.fm; s=dk; t=1788774385; bh=1IVuQ9U4trB4ZPIHclI3jr/GrbNDukNvOZV7lT2GCjA=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=YRxWttTdJbYposjdFGSezTXawacAM+6/tDqyQ473gvLxhv5B7NvpAQa7/T1Iwe2CC UiCkMm+P7blpuHaSRIP4DVIgNTkf4oITgUkI2ZcJLvuH6aMvojSZXrNNwGrkQgK9hR 2d2zhh/OgIZUsWxuEdu+ocCRJHUvmrIbjNt+0zBM= On wrz 04, 2026 11:25, Johannes Berg wrote: > On Thu, 2026-08-13 at 11:04 +0200, Slawomir Stepien wrote: > > > > case NL80211_IFTYPE_P2P_GO: > > + /* Add a new station only after the AP and link has been started */ > > + link_id = wdev->valid_links ? params.link_sta_params.link_id : 0; > > max() maybe? But wouldn't that blur the intent here? It's not about a bigger value. It's about MLO or not MLO device handling. > > + if (!wdev->links[link_id].ap.beacon_interval) > > + return -ENETDOWN; > > I think the same issue might exist also for mesh, maybe address that as > well? Sure, I will take a look at this. > And I think you could have a fourth patch to clean up the mac80211 code > to no longer handle the "STA creation on AP_VLAN" case? Sure, will take a look on that too. Thanks for review! -- Slawomir Stepien