From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A2A51B78F3 for ; Tue, 6 Oct 2026 04:19:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791260357; cv=none; b=WdSxtJqttN80rxvPnorWtBYS/w93vpGeAu3atTvoQO1ogMdaJ/gMzAfv/kYuJrkBiJK7EwawJoJPVsHDdL9wfSUMB3rJIw6bRRZ+ZdHrXfYRwtggdGUTFgIHJsP/QI992+n3LgnwkYQjxFRRxmWbdjIH3thGbodFKTbk/sED1Qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791260357; c=relaxed/simple; bh=k3RSUY4fxdXMS3ZnKpvJScrf6J75V/fZ8Jp7axykJk8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aENv8NW3++BgphdDj6But5Bby4V1XstznpF5T4sjE485ZlW07smKnZA9jT05FcVvAPVztz+2drZF6muP0G7JPFozGfwxQRi506JWM4JAmpzTfpQdA2S5FGehtdhLs749NzASa/agtbAqiVpuwbxeXtNkht6ZoYAuTGqy6324YQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IbPgxINj; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IbPgxINj" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4a018dc1f98so2896925e9.3 for ; Mon, 05 Oct 2026 21:19:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791260354; x=1791865154; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=b4cq9NsXa/9Ah4XIfTqt/umKWCh8D9nJZ3hIc35Disk=; b=IbPgxINjCvplytLmNPCsTLTmB1c1v2BFp0asKSns/n0IdBsxtShIzICiNTsd2ulGjh T8NQJRAjilYMaiXgC9v6HEjmI1dAgNbq2YOnQt7kYTXpr/s3Q/QSwZG/I1HWTNxeRHty PUcTxY4HxKBPeDT2kzLsOXLeaW9FNQ6m/yuqYYgBk4BuNHtRdDoKAKtS0heuTEbEthd1 0iwJtXZPU23/Xjw4Lb6xi867SfUvTExj7RAaw0e7XCHsZpj2nbY4dO4wn52LNRGS7F2f bbOMtAtLiD9b4cMOaL17FZq/NoX2w6DE7S+wovPWkxywPfwgXxcgaQFv6X8g7Lm14+5r CPUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791260354; x=1791865154; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=b4cq9NsXa/9Ah4XIfTqt/umKWCh8D9nJZ3hIc35Disk=; b=g9Te4dVhX/9Uc24RTjdACqPR9/4P0732+qiXCscEku/ulsM6pbC5BR41gQADx4cN4S 3w27d602hC0Zw6NtoKsBgAE5TQrEdPRbTs+gWLZB7hlW1gq/Gh7GPm9XDS99n/o5JIqw KmRoYGWlylFYXE2yC42qJ1qKRufacvzBdKp405OpPME1M5GgND8wSELPRHB9xoJvl/19 SHtdHWmXvoMkeAMQegN7aRrGGl0wGlMT1NOZ799Z6TG8aaTN3lWZExFslbmo2FwsZitw d27OHo50clZXPVSEHp+HRlVkeAsgtO2xthgZuY46pvDmtw3kCiRD/XqBe21pq3lBilQ1 Fh9A== X-Gm-Message-State: AFuF++kOogF0bt7MoEi6UJZuApyrApOg/v17IHU5hgWji+qL25RT6tyO xblyBxFjqba+WQpvCrbI+M7Ua9b+Akrjaj0k/ACuAFiDYVqld2TaJP+N X-Gm-Gg: AYBFou3+1Pl1eZWAGBLEd+u5lUv3pMUte7QWBCR1MvO7yloTzp/t/XFR+WCYPGUnO4w C6RdfDJxAvpn53hsnHIVsI9LtZDNgERICnp0A8pPJsp2b5m5HVXU+qOU3Yj756Rq8FB2bAiZOvu VWd+gTgoSISbKOAog2UZ/qEwE7f+Lx2bH1xhrrLn1UcS+70p/kUoqbTLQuVH4qVzZ3WER/wnPn3 tPj8RbN5LlcjEKhTrlnLAzjqlR9kEm5oENrfiTt6OAGLWYhczDBGZ9loVf+JiUIGguTMdoUAhaA I4BlZcYNyGFxOQgGHrSsaigtcJTMPCoArzy7H/eZNzYylayqPMfsa0okrkeI40moQMG59GVinq/ B2KmRtka3Gy0+6kAR603EHoFJjM8DY7JuxA13VTzMjHJ6mKsSiJepKuL2JKicedk2S9OR6qtpYE 6Muxw8iggJZQUo1j86gx/2AGp/P4B65EjLJqAglkC4r2R+YSNZb/NAr3zqWhCEhFp7EDiZmWcA6 9jEDiQ0IH8BAvG2LOd4H4oga6kBSMS8uCUV123Bevpv2uhH2Um0QyRDrtQkxhmFt5OXAWUmy6mY 1N6o1coh1WZsmCgwkCRbE6XifDkWC+RgwQ== X-Received: by 2002:a05:600c:3510:b0:4a0:1c43:3c04 with SMTP id 5b1f17b1804b1-4a17b53e298mr3201995e9.13.1791260353780; Mon, 05 Oct 2026 21:19:13 -0700 (PDT) Received: from MacBook-Pro-von-Karl (dynamic-095-117-040-097.95.117.pool.telefonica.de. [95.117.40.97]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1776cfe45sm44826795e9.1.2026.10.05.21.19.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2026 21:19:13 -0700 (PDT) Date: Tue, 6 Oct 2026 06:18:41 +0200 From: Karl Mehltretter To: Arend van Spriel Cc: linux-wireless@vger.kernel.org, Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , "David S . Miller" , Eric Dumazet , brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH] wifi: brcmfmac: avoid sleeping tx locks in netpoll context Message-ID: References: <20260930185417.61865-1-kmehltretter@gmail.com> <20261004122910.1392318-1-arend.vanspriel@broadcom.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261004122910.1392318-1-arend.vanspriel@broadcom.com> On Sun, Oct 04, 2026 at 05:29:10AM +0100, Arend van Spriel wrote: > Is there an opportunity to reuse/refactor brcmf_sdio_prec_enq() rather than > adding a separate brcmf_sdio_prec_enq_irqoff() helper? For example, passing > a can_evict parameter: > Thanks for the review! Sharing the helper with a can_evict argument is cleaner. One queue user does not hold txq_lock: brcmf_fws_bus_txq_cleanup() dequeues through brcmu_pktq_pdeq_match(). Lockdep instrumentation in fcmode=1 and 2 confirmed that cleanup enters without txq_lock. I combined the helpers, but kept brcmu_pktq_penq() for normal calls. Karl