From: Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>
To: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Cc: Jeff Johnson <jjohnson@kernel.org>, Kalle Valo <kvalo@kernel.org>,
Baochen Qiang <quic_bqiang@quicinc.com>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
linux-wireless@vger.kernel.org, ath12k@lists.infradead.org
Subject: Re: [PATCH ath-current v2] wifi: ath12k: fix DMA direction for re-injected Rx buffers
Date: Fri, 23 Oct 2026 14:40:53 +0200 [thread overview]
Message-ID: <attV1TkT-pGiU-ZT@lore-desk> (raw)
In-Reply-To: <2467a07c-e215-4cfa-82ac-22214a144dae@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
>
>
> On 10/23/2026 5:25 PM, Lorenzo Bianconi wrote:
>
> > @@ -983,8 +980,8 @@ static int ath12k_wifi7_dp_rx_h_defrag_reo_reinject(struct ath12k_dp *dp,
> > list_add_tail(&desc_info->list, &dp->rx_desc_free_list);
> > spin_unlock_bh(&dp->rx_desc_lock);
> > err_unmap_dma:
> > - dma_unmap_single(dp->dev, buf_paddr, defrag_skb->len + skb_tailroom(defrag_skb),
> > - DMA_TO_DEVICE);
> > + ath12k_dp_unmap_rx_buf(dp, defrag_skb);
>
> buf_paddr has not been updated to skb_cb->paddr when we reach here. v1 has
>
> rxcb->paddr = buf_paddr;
>
> before jumping, so v1 is good.
Right, my bad. I will fix it in v3.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-10-23 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 9:25 [PATCH ath-current v2] wifi: ath12k: fix DMA direction for re-injected Rx buffers Lorenzo Bianconi
2026-10-23 11:04 ` Baochen Qiang
2026-10-23 12:40 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=attV1TkT-pGiU-ZT@lore-desk \
--to=lorenzo.bianconi@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox