From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793910900; b=25qQjX9elgnDrcuZJ8v0EJi61e4R91q2bfy9IwQnUjIGXZNFvPQvnS7mNYtjucTxwqE2 gJ3eHJtq7qS1XlcxWX6Mpo5AHGRTSP1M6eA5JN2fB5P4oFIQiKdvsqJalCzyFsgmS9nTr /pN7iTQQ3Bzf+uenar0UN0U9OxghExdKjvieuEPV1RI9I164sgqVR8WdsPTgotRqYzCzo l3YcVyf+DTUBk4NiKxvflt3y7Itv0vIrQeXMPRvKuQA6N9Ajgp1XJuWWF3udD6VbY1t1S RMsrHRvScuYR0zXO2Xv3hoJpQrj0wIrSjlC135A1oCC3JcjDYZeCKPFCB6QubTQ7PcA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793910900; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=aFjl/l4WKV+VfugNVUlnSUSxj2ZFcfM53muFdv6vcfQ=; b=SEO+LrXFl+NOjSr1YaqrRiXRm7EgoaeN6eEIr6v47R7K+uaEJZuH2RRCux7M0d0+VAo7 EVYOALt2yYlR61SfhxDyuXdcWxxzIIv4FrJhF88tRFWeeXY5xQbw9eVHbtTFlOgliTeMH eNEMcuG/LMLxz+faj3K25S/z7SRrFwUHmRboZLwA7tWvbORmtb9DfYctxpsbOu5reF+bQ OiR2kFGp4NV2oHYiJmiDqh/EXLz5QtoE/jMSoTw6HnZVwDiFVEJ0DfhoDsmWSNP8uEEcd W/JzWyTVSvw4ulQWbAnKfrsK6JIt2tqRK6W2ldfycS/rmbK4NGrR/ZmL9QfIqBvvfow== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=tfDV8RqH; arc=none smtp.remote-ip=74.125.82.41 Received: from mail-dl1-f41.google.com (mail-dl1-f41.google.com [74.125.82.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B971E606A32C for ; Thu, 5 Nov 2026 20:34:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B971E606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=tfDV8RqH Received: by mail-dl1-f41.google.com with SMTP id a92af1059eb24-1a3c08d6928so621c88.0 for ; Thu, 05 Nov 2026 12:34:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793910899; x=1794515699; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=aFjl/l4WKV+VfugNVUlnSUSxj2ZFcfM53muFdv6vcfQ=; b=tfDV8RqHdxq2Tir67Fgi3R8YmRMnkFni198pbJyN+2f/wlgyg1u3H/zAskp5NHkOv7 tIdkAuAZ8WUJ1kMmFVB+y6fHOz8B/caj8wD6aThvegmX02BzNu06iJykZNQp0y6aCkds RlikDnWVU951ugzrT3mYdlzvFKlHh7U4jsRYSXIG1h4+jf8Ji6Bx4VcBvQSsJCCbdeY9 mB7Z2NGEfuJN8Celqb7oNC5peWi2IHdFiN3NSUJbZlwldHAE4GnOhIkhY+aC2WxclROa S4gSdge+AsM35XlqkfzkRHJ1/+Vy2cjQlMpoMljhOELSER57fCOwoNKU+WxKYNt0B3OE B7JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793910899; x=1794515699; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aFjl/l4WKV+VfugNVUlnSUSxj2ZFcfM53muFdv6vcfQ=; b=arXqwCPmxerxghRJEfO9zG000gwlp9I/eorpUuKZgQjH8dnkzn/PKqjhPGf+2btskc aYTEKZkDVH+ETceEQ5LL0OTKT+C5FfJ4JKlQ0P7UnY+PANXdxtY3r3vv/ICGtexorgau ZtX//RgM05ivCnOIEnXP70aeTDjx2Nn31Qvd/89SYSCVyU3VU3U6XiYKFAr+ALzk4BGH 7j7dceF00GikuoFxlhQ7qcihM9js8+umPXkEbA4kpXWO44M/cm/xlj+CFb38GpziSG+j 5eZDMN4ghy4W1fI8CN2SxwWhAqNUGbDX8per6j5y20JGvI9n9f0EF58pD9PU6yaYZXV3 lI3g== X-Forwarded-Encrypted: i=1; AKwUvBzWAXyUzl1gmnQNVwr9s8x5Ay7BwfmDhWJ2e6m5nYwVe7Us86xZk2CrpBlcKKaTdF/ecrKqYJh0fPbB34jH5w==@vger.kernel.org X-Gm-Message-State: APuU4Z/hsxs70TvwYeTmc+xdDi82U5AkZ2p1mZF2V0g47URIYrnCparq rRRhA8UVkdtQum5lQZA8Cwus5DSGdWnDBOMLsypgy9j7Y3P+CWqBNGpI X-Gm-Gg: AYBFou3JJ8e7Z8UI3awQIimgbnA2EZHPs5inZP1F5ZX+pXhC7n4SnEQ/lWsBc75WsZO y1O3tZPW7iGb1cRXkkP/RoZ8oXRJ2eCzvU8dJBAeupgAZIHtECUXXGdUoh0u1gq6rIJieYnxvIN 98HwAJNYK2JsLP/ls4rkkYU8SzgusXhJJW6RlpkU5UvlijLjcOpVGM//u7dTOtQAicJ+N4vex7q WJ4VdIpuDrKvtvVBs/JFMgbsRfcxFvQiEjmJWFaNnUzOdcykHWJZzZq+e/Ul+5MEyZ6D5o+ny5W z8OzlE+DJlGsuiVmxDuyW1E2SYjH5ACCdDK9cIZ3wF+bTYuOiaC+x0jMCK9oGBW5DGtuecXM8Hy afaULsZ2lvLl4ytafr6nODa+0t8wQ1BSlIrvKClYmGWzQ1mxIYrcn/LFXapYibk/qYNGGeixbjX ffGEb96GJYSX8kPbbLjcY+8nq7QKGQ/DzDOR9uVA7JiUE75Em1yNQ5a2JhVVjtw2VDV2ToN48Yi m2MgwENo5GjUQ2WX0Y1JSRac3hxQ2TonAMnFxXPQAnTjJvFVlrQ5gikgLrOrFfLW+H2+10dsuRL 0AKGOYtWi9qMvYSwIDk5Zm/7BiH5PbyoWbzqIanBRd+slCUnEn1liCvBqbzCMATnr2JRPxM= X-Received: by 2002:a05:701b:2050:20b0:166:5552:780a with SMTP id a92af1059eb24-1b25d31e5a2mr163714c88.8.1793910898553; Thu, 05 Nov 2026 12:34:58 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:c8f4:b7d9:252f:4483]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36f722ed274sm649631eec.18.2026.11.05.12.34.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2026 12:34:57 -0800 (PST) Date: Thu, 5 Nov 2026 12:34:53 -0800 From: Dmitry Torokhov To: Leon Romanovsky Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Johannes Berg , Jonathan Corbet , Shuah Khan , Randy Dunlap , Bjorn Helgaas , "Joerg Roedel (AMD)" , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , Robin Murphy , David Woodhouse , Lu Baolu , Johan Hovold , Eric Dumazet , Marcel Holtmann , Luiz Augusto von Dentz , Nipun Gupta , Nikhil Agarwal , Pieter Jansen van Vuuren , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, iommu@lists.linux.dev, Jason Gunthorpe Subject: Re: [PATCH 02/17] Input: serio - attach manual drivers through the driver core Message-ID: References: <20261105-device-trust-core-v1-0-1e536825b4eb@nvidia.com> <20261105-device-trust-core-v1-2-1e536825b4eb@nvidia.com> <20261105191940.GI8298@unreal> X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261105191940.GI8298@unreal> On Thu, Nov 05, 2026 at 09:19:40PM +0200, Leon Romanovsky wrote: > On Thu, Nov 05, 2026 at 09:05:29AM -0800, Dmitry Torokhov wrote: > > On Thu, Nov 05, 2026 at 01:42:15PM +0200, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Manual serio binding connects a driver before driver core can admit the > > > device. A rejected binding therefore arrives after functional setup. > > > > > > Keep the port ID check and use device_driver_attach() for the existing bus > > > probe path. Driver core then serializes admission and handles probe failure > > > before publishing the binding. > > > > > > Signed-off-by: Leon Romanovsky > > > --- > > > drivers/input/serio/serio.c | 24 +++--------------------- > > > 1 file changed, 3 insertions(+), 21 deletions(-) > > > > > > diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c > > > index 54dd26249b027..604440244c1ca 100644 > > > --- a/drivers/input/serio/serio.c > > > +++ b/drivers/input/serio/serio.c > > > @@ -81,28 +81,10 @@ static int serio_match_port(const struct serio_device_id *ids, struct serio *ser > > > > > > static int serio_bind_driver(struct serio *serio, struct serio_driver *drv) > > > { > > > - int error; > > > - > > > - if (serio_match_port(drv->id_table, serio)) { > > > - > > > - serio->dev.driver = &drv->driver; > > > - if (serio_connect_driver(serio, drv)) { > > > - serio->dev.driver = NULL; > > > - return -ENODEV; > > > - } > > > + if (!serio_match_port(drv->id_table, serio)) > > > + return 0; > > > > > > - error = device_bind_driver(&serio->dev); > > > - if (error) { > > > - dev_warn(&serio->dev, > > > - "device_bind_driver() failed for %s (%s) and %s, error: %d\n", > > > - serio->phys, serio->name, > > > - drv->description, error); > > > - serio_disconnect_driver(serio); > > > - serio->dev.driver = NULL; > > > - return error; > > > - } > > > - } > > > - return 0; > > > + return device_driver_attach(&drv->driver, &serio->dev); > > > > I am not sure how safe it is, serio (and gameport) have pretty elaborate > > structure and locking rules because they can recurse into themselves (to > > support case of Synaptics touch-pads with pass-through PS/2 ports). > > > > But this call is for user-initiated probing anyways, I am not sure if it > > even needs "trust" handling. > > This patch does not change the locking; the lock was already held on paths such > as the rescan path. This change makes that explicit. Does this enforce synchronous probing? Anyway, I would like to get rid of this special probing in serio core. Given that the code path is only triggered by explicit user request I do not believe we need to worry about supporting trust notion here, so please drop it from the series. Thanks. -- Dmitry