From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: SPDX identifier
Date: Thu, 16 May 2019 13:35:59 +0200 [thread overview]
Message-ID: <b04655c7-5a6e-b510-5fcf-30ecca489882@broadcom.com> (raw)
Hi Kalle, Thomas,
I added SPDX tags in brcm80211 driver sources. Although it is a
no-brainer I decided to run checkpatch for the changes and quirky stuff
started to happen. For all files I added:
// SPDX-License-Identifier
but checkpatch started complaining I should use /* ... */ instead of //.
WARNING: Improper SPDX comment style for
'drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h', please
use '/*' instead
#29: FILE: drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h:1:
+// SPDX-License-Identifier: ISC
So I edited all patches and ran again. And again it started complaining.
WARNING: Improper SPDX comment style for
'drivers/net/wireless/broadcom/brcm80211/brcmsmac/aiutils.c', please use
'//' instead
So now I am in a bonkers state. It seems for header files we want /* */
and for c files we want //. For real?
This is on wireless-drivers-next so maybe it is already fixed, but I
think this should be fixed.
Regards,
Arend
next reply other threads:[~2019-05-16 11:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 11:35 Arend Van Spriel [this message]
2019-05-16 14:17 ` SPDX identifier James Hughes
2019-05-16 17:02 ` Arend Van Spriel
2019-05-16 18:17 ` Thomas Gleixner
2019-05-16 19:48 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b04655c7-5a6e-b510-5fcf-30ecca489882@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox